Make all adapters https #4294

sumit116 · 2019-10-14T10:41:56Z

Type of change

Refactoring

Description of change

Update all adapters' endpoints or any third party urls used by adapter to https protocol.

Other information

We didn't include those adapters in this PR that had conflict with #4249 and would update them after they are submitted from the respective authors.

For some adapters which have multiple end points like test, staging, prod, etc, we have created github issues to clarify things or make changes on their own. Here is the list of those issues:

jsnellbaker · 2019-10-15T14:03:26Z

modules/appnexusBidAdapter.js

@@ -36,7 +36,7 @@ const SOURCE = 'pbjs';
 const MAX_IMPS_PER_REQUEST = 15;
 const mappingFileUrl = '//acdn.adnxs.com/prebid/appnexus-mapping/mappings.json';
 const SCRIPT_TAG_START = '<script';
-const VIEWABILITY_URL_START = /http:\/\/cdn\.adnxs\.com\/v/;
+const VIEWABILITY_URL_START = /https:\/\/cdn\.adnxs\.com\/v/;


This does not need to be changed, we actually need the regex to not include the protocol. We need to change the protocol for this script later in the adapter code so that when it's written to the page, it'll use https.

When the bid returns from the adserver, the default viewability script will be using a protocol that's read from the page. So it would come in as either http or https. Because of this variability, the regex needs to be non-specific.

excluded the protocol from regex.

… make_all_adapters_https # Conflicts: # modules/appnexusBidAdapter.js # test/spec/modules/vidazooBidAdapter_spec.js

jaiminpanchal27 · 2019-10-25T19:47:32Z

@sumit116 Can you resolve conflicts. Also lets sync up offline and merge this before other merge conflicts appear.

… make_all_adapters_https # Conflicts: # modules/ixBidAdapter.js # modules/rubiconBidAdapter.js # test/spec/modules/outconBidAdapter_spec.js

sumit116 · 2019-10-29T13:18:58Z

@sumit116 Can you resolve conflicts. Also lets sync up offline and merge this before other merge conflicts appear.

@jaiminpanchal27 , conflicts resolved.

patmmccann · 2019-10-29T18:12:02Z

districtmdmx still has obj.secure = window.location.protocol === 'https:' ? 1 : 0; so it may return nonsecure inventory even when called on a secure endpoint.

jaiminpanchal27 · 2019-10-30T14:05:32Z

@patmmccann Fair point but with this PR we are only updating the endpoints. We try not to touch other's adapter implementation unless asked to do so or if it breaks our build.

@sumit116 to create an issue on github and tag them to make updates.

sumit116 · 2019-10-30T14:28:59Z

@jaiminpanchal27 , @patmmccann, created github issue #4398

sumit116 · 2019-11-08T14:31:26Z

HI @msm0504 , can you review these changes and let me know your feedback so that we can merge it to 3.0 branch?

patmmccann · 2019-11-20T17:44:33Z

just want to point out that https://github.com/prebid/Prebid.js/pull/4406/files made my comment above irrelevant to that particular adapter

… make_all_adapters_https # Conflicts: # modules/gridBidAdapter.js # test/spec/modules/ixBidAdapter_spec.js

* Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574)

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases * test cases * test case Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>

update all adapters to https

4ed418f

sumit116 changed the base branch from master to prebid-3.0 October 14, 2019 10:43

jsnellbaker added the Prebid 3.0 label Oct 14, 2019

sumit116 requested review from jsnellbaker and removed request for jsnellbaker October 14, 2019 13:14

bretg requested a review from jaiminpanchal27 October 14, 2019 15:03

bretg assigned jaiminpanchal27 Oct 14, 2019

jsnellbaker reviewed Oct 15, 2019

View reviewed changes

jaiminpanchal27 approved these changes Oct 15, 2019

View reviewed changes

Sumit Sharma1 added 4 commits October 18, 2019 20:12

convert all adapters to https

18965d6

update unit tests

deb0f58

Merge branch 'prebid-3.0' of https://github.com/prebid/Prebid.js into…

6609065

… make_all_adapters_https # Conflicts: # modules/appnexusBidAdapter.js # test/spec/modules/vidazooBidAdapter_spec.js

remove files confilicting with other PR

c96b928

Merge branch 'prebid-3.0' of https://github.com/prebid/Prebid.js into…

8cabe29

… make_all_adapters_https # Conflicts: # modules/ixBidAdapter.js # modules/rubiconBidAdapter.js # test/spec/modules/outconBidAdapter_spec.js

sumit116 mentioned this pull request Oct 30, 2019

districtmdmx adapter - ensure adapter returns secure inventory only #4398

Closed

jaiminpanchal27 requested a review from msm0504 November 4, 2019 03:27

Merge branch 'prebid-3.0' into make_all_adapters_https

5dac934

jsnellbaker approved these changes Nov 8, 2019

View reviewed changes

Merge branch 'prebid-3.0' into make_all_adapters_https

bff2f2e

Merge branch 'prebid-3.0' of https://github.com/prebid/Prebid.js into…

266b473

… make_all_adapters_https # Conflicts: # modules/gridBidAdapter.js # test/spec/modules/ixBidAdapter_spec.js

sumit116 requested a review from robertrmartinez November 21, 2019 15:42

jaiminpanchal27 assigned msm0504 and unassigned jaiminpanchal27 Nov 25, 2019

sumit116 added the needs review label Nov 26, 2019

robertrmartinez approved these changes Nov 26, 2019

View reviewed changes

sumit116 merged commit 3164cfa into prebid-3.0 Nov 26, 2019

sumit116 removed the needs review label Nov 26, 2019

jsnellbaker mentioned this pull request Dec 11, 2019

Prebid 3.0 #4580

Merged

1 task

pm-harshad-mane mentioned this pull request Feb 17, 2020

freewheel-ssp adapter - Update all end points to https #4307

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make all adapters https #4294

Make all adapters https #4294

sumit116 commented Oct 14, 2019 •

edited

Loading

jsnellbaker Oct 15, 2019

sumit116 Oct 29, 2019

jaiminpanchal27 commented Oct 25, 2019

sumit116 commented Oct 29, 2019

patmmccann commented Oct 29, 2019

jaiminpanchal27 commented Oct 30, 2019

sumit116 commented Oct 30, 2019

sumit116 commented Nov 8, 2019

patmmccann commented Nov 20, 2019

Make all adapters https #4294

Make all adapters https #4294

Conversation

sumit116 commented Oct 14, 2019 • edited Loading

Type of change

Description of change

Other information

jsnellbaker Oct 15, 2019

Choose a reason for hiding this comment

sumit116 Oct 29, 2019

Choose a reason for hiding this comment

jaiminpanchal27 commented Oct 25, 2019

sumit116 commented Oct 29, 2019

patmmccann commented Oct 29, 2019

jaiminpanchal27 commented Oct 30, 2019

sumit116 commented Oct 30, 2019

sumit116 commented Nov 8, 2019

patmmccann commented Nov 20, 2019

sumit116 commented Oct 14, 2019 •

edited

Loading