Depracate adloader loadscript fn #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reciate-adloader-loadscript-fn
:wq Merge branch 'master' of https://github.com/prebid/Prebid.js into depreciate-adloader-loadscript-fn
…reciate-adloader-loadscript-fn
…reciate-adloader-loadscript-fn
…m/prebid/Prebid.js into depreciate-adloader-loadscript-fn
…reciate-adloader-loadscript-fn
…der-loadscript-fn
9 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jaiminpanchal27
approved these changes
Oct 15, 2019
jaiminpanchal27
added
LGTM
needs 2nd review
@jaiminpanchal27, I tested for oustream and it works fine. loadExternalScript() gets called for all oustream videos which do not have a renderer.render function. @jsnellbaker, can you please review this PR? |
jsnellbaker
approved these changes
Oct 18, 2019
sumit116
removed
needs 2nd review
jsnellbaker
added a commit
that referenced
this pull request
Dec 11, 2019
* Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574)
bretg
pushed a commit
that referenced
this pull request
Jan 15, 2020
* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
bretg
pushed a commit
that referenced
this pull request
Jan 16, 2020
* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * Remove pbs depracated legacy url (#4226) * remove deprecated legacy url from pbs adapter * fix eslint errors * add and update tests for openRtb2 endpoint * sync with master * Revert "sync with master" This reverts commit 8c2b196. * removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236) * Depracate adloader loadscript fn (#4228) * test commit * add callback support to loadExternalScript() * pass moduleCode for renderers * test cases for loadExternalScript() * store callbacks for cached url * fully remove adloader() * call callback() from stub * remove and update function name * getHighestCpmBids only returns non-rendered bids (#4247) * Make all adapters https (#4294) * update all adapters to https * convert all adapters to https * update unit tests * remove files confilicting with other PR * Removed pub common and unified id submodules as defaults in user id module (#4445) * Deprecate user sync (#4241) * deprecate some properties of userSync object * change bid adapter to Appnexus * fix 3 failing test cases * make all unit test cases pass * remove debugger * deprecate support for adUnit.sizes for pubs (#4458) * deprecate support for adUnit.sizes for pubs * remove commented code * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * Deprecations utils.js (#4249) * deprecate domain/referer type functions * delete modules that are using deprecated methods from utils.js * remove reference to getTopWindowLocation * sync with prebid-3.0 branch * remove test suite for getTopWindowLocation * add back md files of all deleted adapters * add md files of deleted analytics adapters * add adapters that are 3.0 compliant * add back the rubicon skipped test * remove min field from priceGranularity feature (#4574) * ccpa support for v3.0 * Update oneVideoBidAdapter_spec.js * Update oneVideoBidAdapter.js * sync pixel chnge * fix * sync * fix * sync * sync * adding gdpr * test cases * test cases * test case Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: coryhammon1 <coryhammon1@gmail.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
#. the main Renderer function uses loadScript to load the Renderer.url as well as handle the potential Renderer.callback field. So, Used loadExternalScript() instead of depreciated loadScript() to load scripts for outstreams.
#. Add functionality to pass callback function to loadExternalScript() which is called after script is loaded or in ready state.
Tested the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: