Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depracate adloader loadscript fn #4228

Merged
merged 15 commits into from
Oct 22, 2019
Merged

Conversation

sumit116
Copy link
Contributor

@sumit116 sumit116 commented Sep 24, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

#. the main Renderer function uses loadScript to load the Renderer.url as well as handle the potential Renderer.callback field. So, Used loadExternalScript() instead of depreciated loadScript() to load scripts for outstreams.
#. Add functionality to pass callback function to loadExternalScript() which is called after script is loaded or in ready state.

Tested the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

@stale
Copy link

stale bot commented Oct 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 14, 2019
@jsnellbaker jsnellbaker added pinned won't be closed by stalebot and removed stale labels Oct 14, 2019
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @sumit116 to do some more testing on outstream

@jaiminpanchal27 jaiminpanchal27 added LGTM needs 2nd review Core module updates require two approvals from the core team labels Oct 15, 2019
@sumit116
Copy link
Contributor Author

sumit116 commented Oct 16, 2019

LGTM. @sumit116 to do some more testing on outstream

@jaiminpanchal27, I tested for oustream and it works fine. loadExternalScript() gets called for all oustream videos which do not have a renderer.render function.

@jsnellbaker, can you please review this PR?

@sumit116 sumit116 merged commit 52f1047 into prebid-3.0 Oct 22, 2019
@sumit116 sumit116 removed needs 2nd review Core module updates require two approvals from the core team pinned won't be closed by stalebot labels Oct 22, 2019
@jsnellbaker jsnellbaker mentioned this pull request Dec 11, 2019
1 task
jsnellbaker added a commit that referenced this pull request Dec 11, 2019
* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)
bretg pushed a commit that referenced this pull request Jan 15, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
bretg pushed a commit that referenced this pull request Jan 16, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* Remove pbs depracated legacy url (#4226)

* remove deprecated legacy url from pbs adapter

* fix eslint errors

* add and update tests for openRtb2 endpoint

* sync with master

* Revert "sync with master"

This reverts commit 8c2b196.

* removed targeting set filter and moved where render status is set to work with safeframe creatives (#4236)

* Depracate adloader loadscript fn (#4228)

* test commit

* add callback support to loadExternalScript()

* pass moduleCode for renderers

* test cases for loadExternalScript()

* store callbacks for cached url

* fully remove adloader()

* call callback() from stub

* remove and update function name

* getHighestCpmBids only returns non-rendered bids (#4247)

* Make all adapters https (#4294)

* update all adapters to https

* convert all adapters to https

* update unit tests

* remove files confilicting with other PR

* Removed pub common and unified id submodules as defaults in user id module (#4445)

* Deprecate user sync (#4241)

* deprecate some properties of userSync object

* change bid adapter to Appnexus

* fix 3 failing test cases

* make all unit test cases pass

* remove debugger

* deprecate support for adUnit.sizes for pubs (#4458)

* deprecate support for adUnit.sizes for pubs

* remove commented code

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* Deprecations utils.js (#4249)

* deprecate domain/referer type functions

* delete modules that are using deprecated methods from utils.js

* remove reference to getTopWindowLocation

* sync with prebid-3.0 branch

* remove test suite for getTopWindowLocation

* add back md files of all deleted adapters

* add md files of deleted analytics adapters

* add adapters that are 3.0 compliant

* add back the rubicon skipped test

* remove min field from priceGranularity feature (#4574)

* ccpa support for v3.0

* Update oneVideoBidAdapter_spec.js

* Update oneVideoBidAdapter.js

* sync pixel chnge

* fix

* sync

* fix

* sync

* sync

* adding gdpr

* test cases

* test cases

* test case

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: r-schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: coryhammon1 <coryhammon1@gmail.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants