Restore return format of bidsBackHandler callback #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -249,12 +249,37 @@ function processCallbacks(callbackQueue) { | |||
| if (utils.isArray(callbackQueue)) { | |||
| for (i = 0; i < callbackQueue.length; i++) { | |||
| var func = callbackQueue[i]; | |||
| func.call(pbjs, pbjs._bidsReceived); | |||
| func.call(pbjs, pbjs._bidsReceived.reduce(groupByPlacement, {})); | |||
There was a problem hiding this comment.
@protonate
Is there a way to reduce _bidsReceived by the requestId on this request? With this implementation we get an expanding list of bids back each time a requestBids is fired...
|
@mkendall07 ready for review & test |
| @@ -32,8 +32,10 @@ var eventValidators = { | |||
|
|
|||
| /* Public vars */ | |||
|
|
|||
| pbjs._auctionRunning = false; | |||
There was a problem hiding this comment.
do we want to put this in pbjs? They can reset this flag to force a new request without clearing the other globals... edit: nvm, implementation works.
protonate
force-pushed
the
bugfix/bids-back-data-structure
branch
from
74f29f2 to
cf98783
Compare
| const requestId = utils.getUniqueIdentifierStr(); | ||
| adUnitCodes = adUnitCodes || getBidderCodes(); | ||
|
|
||
| getBidderCodes().forEach(bidderCode => { |
added 9 commits
May 27, 2016 16:09
If an auction is running don't accept a new request for bids.. This adds a `clearAuction` function to set `auctionRunning` false and to clear `_bidsRequested` and `_bidsReceived`. This is a stopgap measure util #353
…s()`, disambiguate `bidmanager.getBidderCode`
protonate
force-pushed
the
bugfix/bids-back-data-structure
branch
from
eacbb65 to
5653026
Compare
|
LGTM. Thanks @protonate |
| auctionRunning = true; | ||
| pbjs._bidsRequested = []; | ||
| pbjs._bidsReceived = []; | ||
| resetPresetTargeting(); |
There was a problem hiding this comment.
@protonate
I think it makes sense to move this into the setTargetingForGPTAsync function, because this is GPT specific code. Thoughts?
protonate
pushed a commit
that referenced
this pull request
Jun 15, 2016
* a `groupByPlacement` reduce function transforms the bids received array to a map * prevent concurrent bid requests If an auction is running don't accept a new request for bids.. This adds a `clearAuction` function to set `auctionRunning` false and to clear `_bidsRequested` and `_bidsReceived`. This is a stopgap measure util #353 * clear data structures on additional bid request * make auctionRunning private and allow passing adUnits to requestBids * pass adUnitCodes on refresh bids * use adUnitCodes if passed in to requestBids, otherwise `getBidderCodes()`, disambiguate `bidmanager.getBidderCode` * restore use of adUnitCodes to filter adUnits * cherrypick reset targeting merged * clear targeting fixes and test mock * Add GptPubadsDefined check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
groupByPlacementreduce function transforms the bids received array to a map which is passed to thebidsBackHandlercallback. This restores behavior to pre-v0.9.1.