Concurrent refresh #353
Concurrent refresh #353
Conversation
protonate
force-pushed
the
concurrent-refresh
branch
from
fc70bb1 to
db9c120
Compare
|
Im testing this branch using Partial Refresh with PulsePoint adapter causes and error on addBidResponse in the following line: requestTimestamp: getBidSetForBidder(bid.bidderCode).start This is the error: Uncaught TypeError: Cannot read property 'start' of undefined This is the bid received by addBidResponse: |
| @@ -456,12 +496,12 @@ pbjs.registerBidAdapter = function (bidderAdaptor, bidderCode) { | |||
| } | |||
| }; | |||
|
|
|||
| pbjs.bidsAvailableForAdapter = function (bidderCode) { | |||
| pbjs.bidsAvailableForAdapter = function ({ auction, bidderCode }) { | |||
There was a problem hiding this comment.
don't use destructuring here it will break current implementation
If an auction is running don't accept a new request for bids.. This adds a `clearAuction` function to set `auctionRunning` false and to clear `_bidsRequested` and `_bidsReceived`. This is a stopgap measure util #353
* a `groupByPlacement` reduce function transforms the bids received array to a map * prevent concurrent bid requests If an auction is running don't accept a new request for bids.. This adds a `clearAuction` function to set `auctionRunning` false and to clear `_bidsRequested` and `_bidsReceived`. This is a stopgap measure util #353 * clear data structures on additional bid request * make auctionRunning private and allow passing adUnits to requestBids * pass adUnitCodes on refresh bids * use adUnitCodes if passed in to requestBids, otherwise `getBidderCodes()`, disambiguate `bidmanager.getBidderCode` * restore use of adUnitCodes to filter adUnits * cherrypick reset targeting merged * clear targeting fixes and test mock * Add GptPubadsDefined check
|
Closing as work has moved to Prebid Auctions branch and a new PR will be opened from there. |
|
@protonate do you have a TODO list for the auctions branch, i would like to help since we are using our custom solution now to run concurrent bids but we would rather to have official support on it, let me know where we would help you on that branch. |
|
@ialex great, yes, thanks for the help. I've opened the Prebid Auctions PR #386 and working to complete dev on this today. Further updates are pending on this PR but please start taking a look at it to provide any feedback and confirm that these changes will accommodate your use case. At this point TODO items are:
|
* a `groupByPlacement` reduce function transforms the bids received array to a map * prevent concurrent bid requests If an auction is running don't accept a new request for bids.. This adds a `clearAuction` function to set `auctionRunning` false and to clear `_bidsRequested` and `_bidsReceived`. This is a stopgap measure util #353 * clear data structures on additional bid request * make auctionRunning private and allow passing adUnits to requestBids * pass adUnitCodes on refresh bids * use adUnitCodes if passed in to requestBids, otherwise `getBidderCodes()`, disambiguate `bidmanager.getBidderCode` * restore use of adUnitCodes to filter adUnits * cherrypick reset targeting merged * clear targeting fixes and test mock * Add GptPubadsDefined check
No description provided.