Prevent us from returning false for updating suspended vnode trees #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preact suspends it creates a "parked" vnode structure, the real DOM is discarded but the virtual tree remains in-memory. This means that when a component has suspended but never actually mounted that it is absent of any vnode properties. When a suspended tree is unmounted we clear all properties another time but suspense has already cleared `_component` which means that we will never dispose the `effect`, any signal update contained within the component can therefor cause re-renders. With this patch we rely on the __R internal property, people using native Suspense will see this error clear up. A repro can be seen at https://stackblitz.com/edit/vitejs-vite-bzsqxq1w?file=src%2Fsignals-patch.js,src%2Fapp.tsx&terminal=dev - replacing signals-patch with @preact/signals will reproduce the bug.
🦋 Changeset detectedLatest commit: e4bbb66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +36 B (+0.02%) Total Size: 153 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preact suspends it creates a "parked" vnode structure, the real DOM is discarded but the virtual tree remains in-memory. This means that when a component has suspended but never actually mounted that it is absent of any vnode properties.
When a suspended tree is unmounted we clear all properties another time but suspense has already cleared
_componentwhich means that we will never dispose theeffect, any signal update contained within the component can therefor cause re-renders.With this patch we rely on the __R internal property, people using native Suspense will see this error clear up.
A repro can be seen at
https://stackblitz.com/edit/vitejs-vite-bzsqxq1w?file=src%2Fsignals-patch.js,src%2Fapp.tsx&terminal=dev