Skip to content

Avoid scheduling suspense state udpates #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JoviDeCroock wants to merge 1 commit into
base: v10.x
Choose a base branch
from
Open

Avoid scheduling suspense state udpates #5006

JoviDeCroock wants to merge 1 commit into from
+118 −0

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 29, 2026 •
edited
Loading

We should not be able to update a component in a suspended state, even if it has been mounted. This closely relates to preactjs/signals#858

@github-actions
Copy link

github-actions bot commented Jan 29, 2026 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-5.55ms - +3.57ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 +0% - +0% (+0.00ms - +0.07ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +3% (+0.00ms - +1.50ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +3% (-0.74ms - +0.44ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.59ms - +1.17ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +14% (-0.03ms - +0.29ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.46ms - +0.33ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +1% (-1.44ms - +0.40ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +10% (-0.18ms - +0.66ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +2% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local861.56ms - 866.42ms-unsure 🔍
-1% - +0%
-6.35ms - +1.14ms
preact-main863.75ms - 869.44msunsure 🔍
-0% - +1%
-1.14ms - +6.35ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.04ms - 19.04ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.04ms - 19.04msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.38ms - 16.73ms-unsure 🔍
-1% - +1%
-0.16ms - +0.23ms
preact-main16.43ms - 16.61msunsure 🔍
-1% - +1%
-0.23ms - +0.16ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.55ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main1.54ms - 1.55msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local65.89ms - 67.38ms-unsure 🔍
-2% - +1%
-1.32ms - +0.90ms
preact-main66.02ms - 67.67msunsure 🔍
-1% - +2%
-0.90ms - +1.32ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local8.20ms - 8.78ms-unsure 🔍
-7% - +3%
-0.63ms - +0.26ms
preact-main8.34ms - 9.02msunsure 🔍
-3% - +7%
-0.26ms - +0.63ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.54ms-unsure 🔍
-2% - +1%
-0.26ms - +0.13ms
preact-main16.39ms - 16.78msunsure 🔍
-1% - +2%
-0.13ms - +0.26ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5325

  • Commit: 388b894

duration

VersionAvg timevs preact-localvs preact-main
preact-local58.36ms - 59.59ms-faster ✔
0% - 3%
0.17ms - 1.93ms
preact-main59.40ms - 60.65msslower ❌
0% - 3%
0.17ms - 1.93ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.99ms - 3.00msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.31ms - 25.99ms-unsure 🔍
-3% - +1%
-0.83ms - +0.19ms
preact-main25.59ms - 26.35msunsure 🔍
-1% - +3%
-0.19ms - +0.83ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.68ms - 33.83ms-unsure 🔍
-2% - +3%
-0.69ms - +0.88ms
preact-main32.62ms - 33.69msunsure 🔍
-3% - +2%
-0.88ms - +0.69ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local33.34ms - 34.19ms-unsure 🔍
-2% - +2%
-0.55ms - +0.66ms
preact-main33.29ms - 34.14msunsure 🔍
-2% - +2%
-0.66ms - +0.55ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.49ms - 26.89ms-slower ❌
0% - 2%
0.03ms - 0.55ms
preact-main26.23ms - 26.57msfaster ✔
0% - 2%
0.03ms - 0.55ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.65ms - 27.16ms-unsure 🔍
-5% - +3%
-1.42ms - +0.70ms
preact-main26.02ms - 27.51msunsure 🔍
-3% - +5%
-0.70ms - +1.42ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.73ms - 22.19ms-unsure 🔍
-2% - +1%
-0.53ms - +0.13ms
preact-main21.93ms - 22.40msunsure 🔍
-1% - +2%
-0.13ms - +0.53ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 170
  • Built by: CI #5325

  • Commit: 388b894

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.81ms - 1.91ms-unsure 🔍
-4% - +5%
-0.07ms - +0.09ms
preact-main1.79ms - 1.91msunsure 🔍
-5% - +4%
-0.09ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.00ms - 1.05ms-unsure 🔍
-4% - +3%
-0.04ms - +0.04ms
preact-main1.00ms - 1.06msunsure 🔍
-4% - +4%
-0.04ms - +0.04ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.17ms - 32.52ms-unsure 🔍
-1% - +1%
-0.19ms - +0.33ms
preact-main32.08ms - 32.46msunsure 🔍
-1% - +1%
-0.33ms - +0.19ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.25ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k
  • Browser: chrome-headless
  • Sample size: 130
  • Built by: CI #5325

  • Commit: 388b894

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.21ms - 32.29ms-unsure 🔍
-0% - +5%
-0.12ms - +1.44ms
preact-main30.53ms - 31.66msunsure 🔍
-5% - +0%
-1.44ms - +0.12ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.95ms - 2.96ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.95ms - 2.96msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jan 29, 2026 •
edited
Loading

Size Change: +56 B (+0.07%)

Total Size: 79.4 kB

Filename Size Change
compat/dist/compat.js 4.22 kB +14 B (+0.33%)
compat/dist/compat.mjs 4.14 kB +14 B (+0.34%)
compat/dist/compat.module.js 4.14 kB +14 B (+0.34%)
compat/dist/compat.umd.js 4.28 kB +14 B (+0.33%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.78 kB
dist/preact.min.js 4.8 kB
dist/preact.min.module.js 4.8 kB
dist/preact.min.umd.js 4.82 kB
dist/preact.mjs 4.79 kB
dist/preact.module.js 4.79 kB
dist/preact.umd.js 4.83 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the avoid-scheduling-suspense-state-updates branch 2 times, most recently from 6e5965a to c01f094 Compare January 30, 2026 07:12
@JoviDeCroock JoviDeCroock changed the base branch from avoid-accidentally-scheduling-two-updates to main January 30, 2026 16:57
@JoviDeCroock JoviDeCroock force-pushed the avoid-scheduling-suspense-state-updates branch from c01f094 to 88279a9 Compare January 30, 2026 16:57
@JoviDeCroock JoviDeCroock changed the base branch from main to v10.x January 30, 2026 16:57
@JoviDeCroock JoviDeCroock force-pushed the avoid-scheduling-suspense-state-updates branch from 88279a9 to 388b894 Compare January 30, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoviDeCroock @marvinhagemeister