Fix deletion of partly matching datasets #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delete command deleted partly matching dataset, for example ISOs with the same name as the guest. Changed it to exactly match the guestname.
|
Please note that if I am currently testing your PR #142 first. If that does get merged, you will have to move this into the library. |
|
Yes, I am aware of that. No problem. |
The delete command deleted partly matching dataset, for example ISOs with the same name as the guest. Changed it to exactly match the guestname.
|
Switch has been made, conflicts must be resolved. 🐙 |
|
Resolved the conflicts. |
|
Thanks for all your work!!! Lookin good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete command deleted partly matching dataset, for example
ISOs with the same name as the guest.
Changed it to exactly match the guestname.