Move functions from 'iohyve' into lib folder #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved functions from iohve into a lib folder with files named after the rough topic of the functions. This should help when searching specific functions and general overview.
|
Awesome work! This has been in the plan for a long time now. I'll get to testing hopefully this weekend. How extensively have you tested this? |
|
Not that extensive. Have it running on a testing machine at work and on my laptop at home, where I experiment with some Windows guests. But there it works without problems. |
Enabled the copying of lib files during make install
Closed
|
Haven't forgotten about this. Been testing on and off for a few days while working on other projects. Looking good so far. Do you pinky promise to stick around and help out if this gets merged and something breaks because of it down the line? |
|
|
|
I'll keep my tax returns off of GitHub, though. 💸 |
|
Looking good though! Thanks for you work! Hopefully nothing has slipped through the cracks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved functions from iohve into a lib folder with files named after
the rough topic of the functions.
This should help when searching specific functions and general overview.
Still a big commit, but I basicly changed nothing in the script, just rearranged the functions.
The shift to the library would be very nice, because it really helps with overview.