Skip to content

Always update drawable hitobject state on skin change#6151

Merged
smoogipoo merged 3 commits intoppy:masterfrom
peppy:state-update-on-skin-change
Sep 19, 2019
Merged

Always update drawable hitobject state on skin change#6151
smoogipoo merged 3 commits intoppy:masterfrom
peppy:state-update-on-skin-change

Conversation

@peppy
Copy link
Copy Markdown
Member

@peppy peppy commented Sep 18, 2019

Allows mods to apply changes, and state to potentially be more correctly restored after skin-specific changes.

@peppy
Copy link
Copy Markdown
Member Author

peppy commented Sep 19, 2019

This may have regressed rewind behaviour somehow, blocking for now.

@peppy peppy added the blocked/don't merge Don't merge this. label Sep 19, 2019
@smoogipoo smoogipoo merged commit e686bcf into ppy:master Sep 19, 2019
@peppy peppy deleted the state-update-on-skin-change branch September 22, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants