Refactor hit result methods on Ruleset#36639
Merged
peppy merged 3 commits intoppy:masterfrom Feb 10, 2026
Merged
Conversation
bdach
added a commit
to bdach/osu-queue-score-statistics
that referenced
this pull request
Feb 10, 2026
1 task
This was referenced Mar 3, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetHitResults()gets aForDisplaysuffix to the name to indicate its purpose better.GetValidHitResults()becomes public and actually returns all valid hit results rather than ignoring the existence of miss types and technical result types likeIgnoreHitorComboBreak.Notably, of the two aforementioned methods, the latter is only called by the former. All changes to the latter do not have any impact on the former; this was mostly ensured by
GetHitResultsDisplay()ignoring all non-full-miss types andIgnoreHit, I just had to tackComboBreakonto that list.With the structure of everything in hit objects this is kinda horrifyingly difficult to verify the correctness of. I'm only like 90% sure myself. This is because hit results are declared by judgements which are used by hit objects, except judgements only declare maximum hit results, and minimum hit results are implicitly derived from maximum results in
Judgement, unless thatJudgementproperty is overridden, and so on and so forth. So I think the baseline bonus - except being able to use the new public method for actual validation - is at least in cleartext documentation of what results a ruleset actually uses.