Adjust usages of Ruleset.GetHitResultsForDisplay() after game-side rename#355
Merged
peppy merged 3 commits intoppy:masterfrom Feb 11, 2026
Merged
Adjust usages of Ruleset.GetHitResultsForDisplay() after game-side rename#355peppy merged 3 commits intoppy:masterfrom
Ruleset.GetHitResultsForDisplay() after game-side rename#355peppy merged 3 commits intoppy:masterfrom
Conversation
It's still not 100%, because `HitResult.LargeBonus` is still not valid in all rulesets, but `HitResult.Great` is much better than `HitResult.Perfect` as the latter pretty much only works in mania.
peppy
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rulesetosu#36639Adjust usages of
Ruleset.GetHitResultsForDisplay()after game-side renameSee ppy/osu#36639.
Use better hit result types in helper
It's still not 100%, because
HitResult.LargeBonusis still not valid in all rulesets, butHitResult.Greatis much better thanHitResult.Perfectas the latter pretty much only works in mania.