Adjust friend notification logic to fix a few flaws#36348
Merged
smoogipoo merged 1 commit intoppy:masterfrom Jan 15, 2026
Merged
Adjust friend notification logic to fix a few flaws#36348smoogipoo merged 1 commit intoppy:masterfrom
smoogipoo merged 1 commit intoppy:masterfrom
Conversation
- When changing the configuration setting, things were not reset. Likewise, if the setting was off the queues would still be added to but never flushed. - When the setting is toggled, a stale next notification time was still present due to the `??=` and lack of resetting. This should no longer be the case.
smoogipoo
approved these changes
Jan 15, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of things I noticed in passing:
??=and lack of resetting. This should no longer be the case.