Update editor slider controls to new design#36346
Conversation
…o `FormSliderBar`
Joehuu
added
area:editor
type/cosmetic
There was a problem hiding this comment.
LGTM otherwise.
Revert buttons are gone, but you can double click for now. I would suggest encasing these with SettingsItemV2, but let's wait until #36193 is merged. And unsure we should be even using SettingsItemV2 in the editor.
The whole point of that class was "things that only exist in settings". I still don't quite see that vision, but we DEFINITELY CAN'T USE IT HERE. If we're using in the editor, it should be destroyed / merged into the form controls in some way, since this is basically saying "we want that functionality everywhere". |
|
I understand that this is currently a discussion between you and Joseph, but what should I do in this situation? Should I be bothered or not? |
|
Safe to ignore 👍 |
…bindables when `TransferValueOnCommit` is true (#36354) - Addresses #36346 (comment) The inner slider bar binds its `Current` to `currentNumberInstantaneous`: https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L225-L236 But the current bindable of the form component doesn't update because of this. https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L285-L293 Fixed it by just moving the `ResetToDefault` action up another level. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
peppy
changed the title
3 participants
(partially) Closes: #36233
Surpasses: #36244
This PR meant to be one of the last steps that finally make editor use the new forms. Initially it meant to only change one SliderWithTextBoxInput in "Effects section" in timing screen, however soon after it was obvious that there's many other places that still using it. This currently won't affect IndeterminateSliderWithTextBoxInput that is being used in hitsounds, for example, since I think it needs more consideration.
Anyways, with this PR, SliderWithTextBoxInput, will no longer be used at all, as it's going to be replaced with modern FormSliderBar
Comparison: