Skip to content

Move the rest of editor's style to the new form controls#36244

Closed
tadatomix wants to merge 10 commits intoppy:masterfrom
tadatomix:editor/new-form-controls-in-timing
Closed

Move the rest of editor's style to the new form controls#36244
tadatomix wants to merge 10 commits intoppy:masterfrom
tadatomix:editor/new-form-controls-in-timing

Conversation

@tadatomix
Copy link
Copy Markdown
Contributor

@tadatomix tadatomix commented Jan 6, 2026 •
edited
Loading

Closes: #36233

This seemed like an easy fix to do, so I've tried to do my best

master this PR
изображение изображение

tadatomix
tadatomix commented Jan 6, 2026
View reviewed changes
@tadatomix

This comment was marked as resolved.

Sign in to view
@Joehuu
Copy link
Copy Markdown
Member

Joehuu commented Jan 12, 2026 •
edited
Loading

If those usages of SliderWithTextBoxInput are easy to replace like what you've done in this PR currently, then go for it and probably remove that class.

I also see an IndeterminateSliderWithTextBoxInput that's a copy-paste of the above class (i.e. not inherited) with extra logic. I haven't looked closely, but if those two components are together, maybe that will have to be reimplemented with the new design. It is not (only two usages that are alone), so it'll be in another PR.

@tadatomix tadatomix changed the title Replace old SliderWithTextBoxInput with FormSliderBar in editor's effect section Update editor's effect section to the new style Jan 14, 2026
@tadatomix

This comment was marked as resolved.

Sign in to view
@Joehuu
Copy link
Copy Markdown
Member

Joehuu commented Jan 14, 2026 •
edited
Loading

Note that the colons would need to be removed for consistency with the others.

I haven't managed to make some of the textbox focused as they were before change

Copying the TakeFocus() method in SliderWithTextBoxInput to FormSliderBar should work. On a quick test, it seemed to work.

they don't update their changes in real time now

I changed the X slider to the new design, and it seemed to update on value change when I dragged the slider. Are you saying that there's some delay I'm not seeing or is it some other thing?

@tadatomix

This comment was marked as resolved.

Sign in to view
@Joehuu
Copy link
Copy Markdown
Member

Joehuu commented Jan 14, 2026

It did, but I have a slight concern about this warning. Not sure if it's important or not, but seem to be fair to report about it

The same thing happens on SliderWithTextBoxInput, so that's no problem if code quality can't detect it. Worst case is removing the bool aspect of it and just use void.

I'm not sure how you changed it, but the way I did gives this result. Worst case is returning to the default value, since it basically does nothing.

master's code doesn't have TransferValueOnCommit = true, not sure why you added that. Copy-paste mistake?

@tadatomix

This comment was marked as resolved.

Sign in to view
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jan 14, 2026
@tadatomix tadatomix changed the title Update editor's effect section to the new style Move the rest of editor's style to the new form controls Jan 14, 2026
@tadatomix
Copy link
Copy Markdown
Contributor Author

tadatomix commented Jan 14, 2026

Due to the notice of the outdated styles in other places of editor screen, I decided to rename this PR along with adding new forms and removing outdated ones, by suggestion of @Joehuu

@tadatomix tadatomix closed this Jan 14, 2026
@tadatomix tadatomix deleted the editor/new-form-controls-in-timing branch January 14, 2026 21:48
@tadatomix
Copy link
Copy Markdown
Contributor Author

tadatomix commented Jan 14, 2026 •
edited
Loading

Sorry, somehow I fell into the same trap of wanting to rename the branch to fit the topic and forgetting that this can close existing PR. I think since initial topic of this PR has shifted a lot, I'll just reopen PR with a proper branch name, PR title and comparison screenshots

@tadatomix tadatomix mentioned this pull request Jan 14, 2026
Merged
peppy pushed a commit that referenced this pull request Jan 16, 2026
@tadatomix
Update editor slider controls to new design (#36346)
e05b6f4 
(partially) Closes: #36233
Surpasses: #36244 

This PR meant to be one of the last steps that finally make editor use
the new forms. Initially it meant to only change one
SliderWithTextBoxInput in "Effects section" in timing screen, however
soon after it was obvious that there's many other places that still
using it. This currently won't affect
IndeterminateSliderWithTextBoxInput that is being used in hitsounds, for
example, since I think it needs more consideration.
Anyways, with this PR, SliderWithTextBoxInput, will no longer be used at
all, as it's going to be replaced with modern FormSliderBar

Comparison:
|master|this PR|
|:---:|:---:|
|<img width="510" height="316"
alt="532203751-eb965923-d3a8-441d-a7c8-5c364a6328ad"
src="https://github.com/user-attachments/assets/268b45b8-e235-494f-91a5-d00db057dba8"
/>|<img width="540" height="321"
alt="535466527-3a700a8b-bc3c-4610-998f-a4e55ee03eed"
src="https://github.com/user-attachments/assets/20cd4b58-b0bd-49bc-8c48-7de5cf8556b3"
/>|
|<img width="694" height="639"
alt="534509844-f00e4da4-53c4-45e8-80ea-1be62da6c83b"
src="https://github.com/user-attachments/assets/398c4484-a867-4df1-9de3-0940aa748a01"
/>|<img width="720" height="433" alt="изображение"
src="https://github.com/user-attachments/assets/b6359443-a224-4a55-b171-07e8f013cf46"
/>|
|<img width="715" height="353"
alt="534509421-a6ac950f-16e8-4a16-bca6-1a781f82135f"
src="https://github.com/user-attachments/assets/4854312b-772f-4b81-a800-89e58d4c715d"
/>|<img width="710" height="296" alt="изображение"
src="https://github.com/user-attachments/assets/a7fed53e-e006-4285-92c9-bb84cb603f60"
/>|
|<img width="717" height="374"
alt="534509478-80222623-7766-481d-8682-088276d415ee"
src="https://github.com/user-attachments/assets/8143b6dc-4599-45d5-bd3b-f059caf3d93d"
/>|<img width="718" height="328" alt="изображение"
src="https://github.com/user-attachments/assets/bffa04de-983c-45ae-a1ec-373701ea0e49"
/>|
|<img width="702" height="446"
alt="534509935-58954060-7ac1-4392-8754-a58f909e86aa"
src="https://github.com/user-attachments/assets/2bb67a2d-3f57-42a1-96ce-b30b4891e1a4"
/>|<img width="722" height="386" alt="изображение"
src="https://github.com/user-attachments/assets/01b7fff4-7f31-4aac-90c9-353b15f4964e"
/>|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peppy peppy peppy left review comments

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Effect "Scroll Speed" slider in Editor timing screen seem to use outdated style

3 participants

@tadatomix @Joehuu @peppy