Fix score tooltips being displayed when hovering mod status bar#36332
Merged
peppy merged 1 commit intoppy:masterfrom Jan 17, 2026
Merged
Fix score tooltips being displayed when hovering mod status bar#36332peppy merged 1 commit intoppy:masterfrom
peppy merged 1 commit intoppy:masterfrom
Conversation
Member
|
Please un-split this into its own drawable. I can't tell what you've changed. |
peppy
requested changes
Jan 16, 2026
Member
peppy
left a comment
There was a problem hiding this comment.
PR doing refactors and fix at the same = no go
Contributor
Author
i fixed thing that was broken due to the split into a separate class in the previous pull request the splitting itself was also in that pull request, see #34090 (comment) |
fe59c7f to
0f5e2d3
Compare
Member
|
FWIW you can/could add a second commit which splits it out. The important part is that the fix is a separate commit. Else it's nigh impossible to review. |
ModDisplayBar & UnrankedBadge
peppy
approved these changes
Jan 17, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Feb 11, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.