Skip to content

Fix score tooltips being displayed when hovering mod status bar#36332

Merged
peppy merged 1 commit intoppy:masterfrom
diquoks:quick-fix/mods-block-input
Jan 17, 2026
Merged

Fix score tooltips being displayed when hovering mod status bar#36332
peppy merged 1 commit intoppy:masterfrom
diquoks:quick-fix/mods-block-input

Conversation

@diquoks
Copy link
Copy Markdown
Contributor

@diquoks diquoks commented Jan 13, 2026

@peppy
Copy link
Copy Markdown
Member

peppy commented Jan 16, 2026

Please un-split this into its own drawable. I can't tell what you've changed.

Copy link
Copy Markdown
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR doing refactors and fix at the same = no go

@diquoks
Copy link
Copy Markdown
Contributor Author

diquoks commented Jan 16, 2026

Please un-split this into its own drawable. I can't tell what you've changed.

i fixed thing that was broken due to the split into a separate class in the previous pull request

the splitting itself was also in that pull request, see #34090 (comment)

@diquoks diquoks force-pushed the quick-fix/mods-block-input branch from fe59c7f to 0f5e2d3 Compare January 16, 2026 13:05
@pull-request-size pull-request-size bot added size/S and removed size/L labels Jan 16, 2026
@diquoks diquoks requested a review from peppy January 16, 2026 13:05
@peppy
Copy link
Copy Markdown
Member

peppy commented Jan 16, 2026

FWIW you can/could add a second commit which splits it out. The important part is that the fix is a separate commit. Else it's nigh impossible to review.

@peppy peppy changed the title Override input when hovering ModDisplayBar & UnrankedBadge Fix score tooltips being displayed when hovering mod status bar Jan 17, 2026
@peppy peppy merged commit eee88a3 into ppy:master Jan 17, 2026
7 of 9 checks passed
@diquoks diquoks deleted the quick-fix/mods-block-input branch January 17, 2026 16:32
peppy pushed a commit that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants