Use input blocking container for mod display bar#34090
Closed
GSculerlor wants to merge 5 commits intoppy:masterfrom
Closed
Use input blocking container for mod display bar#34090GSculerlor wants to merge 5 commits intoppy:masterfrom
GSculerlor wants to merge 5 commits intoppy:masterfrom
Conversation
bdach
reviewed
Jul 10, 2025
Contributor
Author
|
split into its own composite in ca0f4b0. there should be no visual changes, hopefully. comparing visuals in tests: (master) Screen.Recording.2025-07-11.at.20.05.07.mov(this MR) Screen.Recording.2025-07-11.at.20.04.18.mov |
Joehuu
reviewed
Jul 15, 2025
Member
Joehuu
left a comment
Joehuu
left a comment
There was a problem hiding this comment.
ModCountText still needs protected override bool OnHover(HoverEvent e) => true (leaderboard panel still gets hover highlight).
Screen.Recording.2025-07-14.at.10.48.44.PM.mov
Joehuu
requested changes
Jul 16, 2025
Member
Joehuu
left a comment
Joehuu
left a comment
There was a problem hiding this comment.
Unfortunate that there are no previous tests for the regressions seen in the last commit and this...
| { | ||
| base.LoadComplete(); | ||
|
|
||
| Mods.BindValueChanged(_ => updateDisplay(), true); |
Member
There was a problem hiding this comment.
This needs the ModSettingChangeTracker, else the multiplier won't update:
Screen.Recording.2025-07-16.at.10.20.16.AM.mov
Hopefully you can just move the one from the parent to this component class and not duplicating or passing, haven't tried. The unranked badge will probably not update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #34079
Screen.Recording.2025-07-10.at.01.02.56.mov
309c46f is for consistency since the mod bar display now also consumes event on mouse down (probably need to add a comment there)