Hide cursor during background reveal in song select#36252
Merged
peppy merged 3 commits intoppy:masterfrom Jan 13, 2026
Merged
Conversation
- Implement IProvideCursor in SongSelect to hide cursor when background is revealed - Cursor reappears on mouse movement and hides again after 1 second of inactivity - Fix MenuCursorContainer to preserve drag rotation state during hide/show cycles
|
Supersedes #36248 |
peppy
approved these changes
Jan 9, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
This was referenced Mar 4, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #36238
When using the background reveal feature, the cursor was intrusive and blocked the view of the beatmap background.
This PR makes the cursor fade out in sync with the background reveal animation. The behavior is:
Note: Also includes a small fix to
MenuCursorContainerto preserve cursor rotation state during hide/show cycles. I am not entirely sure if this was needed but I decided to include it to keep cursor rotation while revealing the background.