Hide cursor during background reveal in song select#36248
Closed
UltraDrakon wants to merge 1 commit intoppy:masterfrom
Closed
Hide cursor during background reveal in song select#36248UltraDrakon wants to merge 1 commit intoppy:masterfrom
UltraDrakon wants to merge 1 commit intoppy:masterfrom
Conversation
Member
|
If we're even considering allowing local control of cursor visibility using a new method, it needs to be lease based. But more importantly, we have a system for hiding the cursor, see usages. |
Member
|
I'd recommend you attempt this again using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #36238
When using the background reveal feature, the cursor was intrusive and blocked the view of the beatmap background.
This PR makes the cursor fade out in sync with the background reveal animation. The behavior is: