Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap beatmap listing filters and match web spacing #27541

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Mar 8, 2024

Had this change but thought it was unimportant at the time (a month ago) and the design is changing again. My intention at the time was to fix the display for high ui scales but didn't account for other languages.

Before After Web
Screenshot 2024-03-08 at 12 09 12 PM Screenshot 2024-03-08 at 12 07 18 PM Screenshot 2024-03-08 at 12 14 45 PM

@bdach
Copy link
Collaborator

bdach commented Mar 11, 2024

the design is changing again

I've seen this months ago already. And it probably hasn't been reviewed by anyone yet, so I wouldn't worry about it.

@bdach bdach self-requested a review March 11, 2024 13:49
@bdach
Copy link
Collaborator

bdach commented Mar 11, 2024

Tacked on e5e7c8f while we're here. Seems fine otherwise.

@bdach bdach enabled auto-merge March 11, 2024 14:05
@bdach bdach merged commit 2b40eff into ppy:master Mar 11, 2024
10 of 11 checks passed
@Joehuu Joehuu deleted the wrap-beatmap-listing-filters branch March 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't scroll through drop-down lists in osu!direct
2 participants