[Resource] Refactor ibm_pi_placement_group resource #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkad
reviewed
Apr 29, 2024
Comment on lines
960
to
961
| Pending: []string{"notdone"}, | ||
| Target: []string{"done"}, |
There was a problem hiding this comment.
We can have them as adding and added for pending and target.
…m into resource-placement-group
michaelkad
reviewed
May 2, 2024
| Required: true, | ||
| Type: schema.TypeString, | ||
| ValidateFunc: validate.ValidateAllowedStringValues([]string{"affinity", "anti-affinity"}), |
There was a problem hiding this comment.
I have added allowed value in the constant file for those two as:
// Allowed Values
Affinity = "affinity"
AntiAffinity = "anti-affinity"
michaelkad
requested changes
May 3, 2024
| @@ -944,12 +953,76 @@ func isPIInstanceRefreshFunc(client *st.IBMPIInstanceClient, id, instanceReadySt | |||
| } | |||
| } | |||
|
|
|||
| func isWaitForPIInstancePlacementGroupAdd(ctx context.Context, client *st.IBMPIPlacementGroupClient, pgID string, id string) (interface{}, error) { | |||
There was a problem hiding this comment.
Could you add constant for the one you just added ? adding, added, 'deleting', 'deleted'
…m into resource-placement-group
…raform-provider-ibm into resource-placement-group
michaelkad
approved these changes
May 3, 2024
|
Opened in main terraform repo: IBM-Cloud#5335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: