Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ibm_pi_placement_group resource #5335

Merged
merged 15 commits into from
May 14, 2024

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented May 6, 2024

This PR refactors the ibm_pi_placement_group resource and cleans up the code.

--- PASS: TestAccIBMPIPlacementGroupBasic (3601.37s)
PASS

@ismirlia ismirlia requested a review from yussufsh May 9, 2024 14:12
@ismirlia
Copy link
Collaborator Author

@yussufsh I fixed the merge conflicts.

Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yussufsh yussufsh merged commit 2aa8b25 into IBM-Cloud:master May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants