Skip to content

bug(data frame): Make sure all original patch locations exit saving state #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 15, 2024
Merged

bug(data frame): Make sure all original patch locations exit saving state #1529

merged 7 commits into from
Jul 15, 2024

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Jul 15, 2024

Original posted by @maxmoro in #1449 (comment) and https://discord.com/channels/1109483223987277844/1258826016403623976/1258826018181877823

If cell [x,y] was edited & saved, and the patch function returned any cell other than [x,y], the original cell location would never leave the saving state.

Now, if the cell is in the saving state, the cell will be returned to the ready state with the original value. Immediately after this, all patches will be saved. While not optimal, the simplicity is effective and the data that is reset is done in the same execution tick.

@schloerke schloerke added the data frame Related to @render.data_frame label Jul 15, 2024
@schloerke schloerke added this to the v1.0.0 milestone Jul 15, 2024
@schloerke schloerke marked this pull request as ready for review July 15, 2024 15:57
@schloerke schloerke mentioned this pull request Jul 15, 2024
Closed
@schloerke schloerke changed the title bug(data frame): Be sure all original patch locations exit saving state bug(data frame): Make sure all original patch locations exit saving state Jul 15, 2024
@schloerke schloerke enabled auto-merge July 15, 2024 16:34
@schloerke schloerke added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@schloerke schloerke added this pull request to the merge queue Jul 15, 2024
@schloerke schloerke removed this pull request from the merge queue due to a manual request Jul 15, 2024
@schloerke schloerke enabled auto-merge July 15, 2024 18:05
@schloerke schloerke added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit a393b49 Jul 15, 2024
@schloerke schloerke deleted the df_update_patch_cell_state branch July 15, 2024 19:09
schloerke added a commit that referenced this pull request Jul 15, 2024
@schloerke
Merge branch 'main' into df-docs
966bf51 
* main:
  bug(data frame): Make sure all original patch locations exit saving state (#1529)
  bug(TS): Update deps to latest versions:  (#1524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

data frame Related to @render.data_frame

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@schloerke