Merge branch 'main' into df-docs

* main:
  bug(data frame): Make sure all original patch locations exit saving state (#1529)
  bug(TS): Update deps to latest versions:  (#1524)

Author: schloerke

CHANGELOG.md

@@ -55,8 +55,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Fixed #1440: When a Shiny Express app with a `www/` subdirectory was deployed to shinyapps.io or a Connect server, it would not start correctly. (#1442)
 
+* Fixed #1498: Update table related TypeScript dependencies to their latest versions. This fixed an issue where the Row Virtualizer would scroll to the end when hidden. This would cause the DOM to update numerous times, locking up the browser tab for multiple seconds. #1524
+
 * The return type for the data frame patch function now returns a list of `render.CellPatch` objects (which support `htmltools.TagNode` for the `value` attribute). These values will be set inside the data frame's `.data_view()` result. This also means that `.cell_patches()` will be a list of `render.CellPatch` objects.  (#1526)
 
+* Made sure all `@render.data_frame` cells that have been edited are now restored back to ready state to handle the off chance that the returned patches are at different locations the the original edit patches. (#1529)
+
+
 ### Other changes
 
 ## [0.10.2] - 2024-05-28

js/data-frame/data-update.tsx

@@ -85,6 +85,21 @@ export function updateCellsData({
           draft[rowIndex]![columnIndex] = value;
         });
       });
+
+      // Set the old patches locations back to success state
+      // This may be overkill, but it guarantees that the incoming patches exit the saving state
+      patches.forEach(({ rowIndex, columnIndex, value }) => {
+        setCellEditMapAtLoc(rowIndex, columnIndex, (obj_draft) => {
+          // If the cell is still saving, then set it back to ready.
+          // If not, then something else has changed the cell state, so don't change it.
+          if (obj_draft.state !== CellStateEnum.EditSaving) return;
+
+          obj_draft.state = CellStateEnum.Ready;
+          obj_draft.value = value;
+          obj_draft.errorTitle = undefined;
+        });
+      });
+      // Set the new patches
       newPatches.forEach(({ rowIndex, columnIndex, value }) => {
         setCellEditMapAtLoc(rowIndex, columnIndex, (obj_draft) => {
           obj_draft.value = value;
@@ -98,7 +113,6 @@ export function updateCellsData({
     .catch((err: string) => {
       patches.forEach(({ rowIndex, columnIndex, value }) => {
         setCellEditMapAtLoc(rowIndex, columnIndex, (obj_draft) => {
-          // Do not overwrite value!
           obj_draft.value = String(value);
 
           obj_draft.state = CellStateEnum.EditFailure;

js/data-frame/filter.tsx

@@ -1,7 +1,7 @@
 import {
+  ColumnFiltersOptions,
   ColumnFiltersState,
   FilterMeta,
-  FiltersOptions,
   Header,
   Row,
   getFacetedMinMaxValues,
@@ -25,7 +25,7 @@ export function useFilters<TData>(enabled: boolean | undefined): {
   columnFilters: ColumnFiltersState;
   setColumnFilters: React.Dispatch<React.SetStateAction<ColumnFiltersState>>;
   columnFiltersState: { columnFilters: ColumnFiltersState };
-  filtersTableOptions: FiltersOptions<TData>;
+  filtersTableOptions: ColumnFiltersOptions<TData>;
 } {
   const [columnFilters, setColumnFilters] = useState<ColumnFiltersState>([]); // can set initial column filter state here
 

js/data-frame/index.tsx

@@ -278,10 +278,11 @@ const ShinyDataGrid: FC<ShinyDataGridProps<unknown>> = ({
     count: table.getFilteredRowModel().rows.length,
     getScrollElement: () => containerRef.current,
     estimateSize: () => 31,
+    overscan: 15,
     paddingStart: theadRef.current?.clientHeight ?? 0,
     // In response to https://github.com/posit-dev/py-shiny/pull/538/files#r1228352446
     // (the default scrollingDelay is 150)
-    scrollingDelay: 10,
+    isScrollingResetDelay: 10,
   });
 
   // Reset scroll when dataset changes

js/data-frame/table-summary.tsx

@@ -13,7 +13,7 @@ import React, { useMemo } from "react";
 export function useSummary(
   summaryTemplate: string | boolean | undefined,
   scrollContainer: HTMLElement | null,
-  virtualRows: VirtualItem[],
+  virtualRows: VirtualItem<Element>[],
   thead: HTMLTableSectionElement | null,
   nrows: number
 ): JSX.Element | null {