-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging prerelease/2025.03 to main #6558
Conversation
v0.1.169 fixes a deadlock when starting reticulate sessions. It would be great to get it included in 2025.03 release. See: posit-dev/ark#728
Update `product.json` to provide the most recent release of each bootstrapped extension we're providing. Otherwise, when users have AutoUpdate enabled, at first launch, Positron will do two back-to-back installs. This was causing issues with our automation that required skipping the Problems tests in #6537 ### QA Notes @:problems
… than the application directory (#6554) @midleman and @testlabauto reported that their tests relying on extensions were failing locally. This is because the bootstrapped extension feature was saving `.version` to the application folder rather than the user's extension folder, causing the bootstrapped extensions to only be installed for the first user that launched the application. Because the tests use a temporary user data directory per run, the extensions would not be installed on subsequent runs. This would've prevented extensions from being installed for multiple users on Workbench as well. We now create, look for, and update `.version` in the user's extension directory rather that the application directory. In the implementation, `storageFilePath` was unnecessarily being declared as a class member so I fixed that as well.
E2E Tests 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have another change I'd like to merge from the prerelease branch into main if we're okay to wait for CI on #6552 and bring that change here! |
An update that #6552 CI checks are green and it's ready to merge. #6552 is targeted to the |
b9ab841
to
f7be371
Compare
I'm going to close this as I want to resolve the failure I'm seeing first. |
Capturing any work done on the prerelease/2025.03 branch to main.
Ignoring the ark bump as main had since moved to v0.1.170.
It looked like QA's changes were duplicated to main already on #6522, so it ended up being a no-op, but probably best to merge the history rather than re-do on main in future.