Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create the bootstrap .version file in the extensions directory rather than the application directory #6554

Merged

Conversation

melissa-barca
Copy link
Contributor

@midleman and @testlabauto reported that their tests relying on extensions were failing locally. This is because the bootstrapped extension feature was saving .version to the application folder rather than the user's extension folder, causing the bootstrapped extensions to only be installed for the first user that launched the application. Because the tests use a temporary user data directory per run, the extensions would not be installed on subsequent runs.

This would've prevented extensions from being installed for multiple users on Workbench as well.

We now create, look for, and update .version in the user's extension directory rather that the application directory.

In the implementation, storageFilePath was unnecessarily being declared as a class member so I fixed that as well.

Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Problem is fixed. Verified locally.

@melissa-barca melissa-barca merged commit f7be371 into prerelease/2025.03 Feb 28, 2025
8 checks passed
@melissa-barca melissa-barca deleted the bugfix/move-bootstrap-version-file branch February 28, 2025 19:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants