create the bootstrap .version file in the extensions directory rather than the application directory #6554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@midleman and @testlabauto reported that their tests relying on extensions were failing locally. This is because the bootstrapped extension feature was saving
.version
to the application folder rather than the user's extension folder, causing the bootstrapped extensions to only be installed for the first user that launched the application. Because the tests use a temporary user data directory per run, the extensions would not be installed on subsequent runs.This would've prevented extensions from being installed for multiple users on Workbench as well.
We now create, look for, and update
.version
in the user's extension directory rather that the application directory.In the implementation,
storageFilePath
was unnecessarily being declared as a class member so I fixed that as well.