Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retention for data summary collapses triggered by splitter button and resizing #6520

Closed
wants to merge 2 commits into from
Closed

Fix retention for data summary collapses triggered by splitter button and resizing #6520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
689253e
Fix data summary button collapse retention
kv9898 Feb 27, 2025
a6815d1
remove redundant line
kv9898 Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...nch/browser/positronDataExplorer/components/dataExplorerPanel/components/dataExplorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ export const DataExplorer = () => {
onCollapsedChanged={collapsed => {
setAnimateColumnsWidth(!context.accessibilityService.isMotionReduced());
setColumnsCollapsed(collapsed);
if (collapsed) {
context.instance.collapseSummary();
} else {
context.instance.expandSummary();
}
Comment on lines +343 to +347
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works after the first attempt. From a fresh Positron start, collapsing it, switching away & back, and returning does not hold state. See video below:

Screen.Recording.2025-02-27.at.10.55.07.AM.mov

I will explore more this afternoon. Do you see this behavior as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... No, it works for me on the first attempt. Does this problem still arise after you restart the Positron development version?

Copy link
Contributor

@samclark2015 samclark2015 Feb 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not right for me, but @softwarenerd was able to confirm that it works as expected... so likely something in my working copy.

}}
onResize={resizeHandler}
/>
Expand Down