Fix retention for data summary collapses triggered by splitter button and resizing #6520
Conversation
| if (collapsed) { | ||
| context.instance.collapseSummary(); | ||
| } else { | ||
| context.instance.expandSummary(); | ||
| } |
There was a problem hiding this comment.
This works after the first attempt. From a fresh Positron start, collapsing it, switching away & back, and returning does not hold state. See video below:
Screen.Recording.2025-02-27.at.10.55.07.AM.mov
I will explore more this afternoon. Do you see this behavior as well?
There was a problem hiding this comment.
Weird... No, it works for me on the first attempt. Does this problem still arise after you restart the Positron development version?
There was a problem hiding this comment.
It's still not right for me, but @softwarenerd was able to confirm that it works as expected... so likely something in my working copy.
...kbench/browser/positronDataExplorer/components/dataExplorerPanel/components/dataExplorer.tsx
Outdated
Show resolved
Hide resolved
|
Feel free to edit my code! |
| if (collapsed) { | ||
| context.instance.collapseSummary(); | ||
| } else { | ||
| context.instance.expandSummary(); | ||
| } |
There was a problem hiding this comment.
It's still not right for me, but @softwarenerd was able to confirm that it works as expected... so likely something in my working copy.
|
@softwarenerd @samclark2015 I do not need to worry about the failed tests or merging, right? Anything else that needs to be done on my part? |
|
Correct, we will merge in today. Thanks again for this! |
|
Merged in #6550 (duplicate of this PR to allow tests to run). |
Release Notes
New Features
Bug Fixes
After this fix, it is also safe to close #5572 .
demonstration1.mp4
QA Notes