Migrate videos to non-tracking option with no cookies #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for positron-posit-co ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
Seems pretty good to me! |
Collaborator
Author
|
The files were not actually that big, so maybe no real need for git lfs. 🤷♀️ |
cindyytong
reviewed
Oct 6, 2025
| ``` | ||
| ::: | ||
|
|
||
| {{< video videos/positron-assistant-copytoeditor.mp4 >}} |
Contributor
There was a problem hiding this comment.
can you still add the aria label to help with accessibility seo
Collaborator
Author
There was a problem hiding this comment.
I opened up quarto-dev/quarto-cli#13508 to add this functionality and @cscheid says he will be able to get this done fairly shortly. I'll open an issue for me to come back to this when it's available in Quarto!
Collaborator
Author
There was a problem hiding this comment.
I have posit-dev/positron#9803 tracking adding the aria labels back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt here is to use local videos in the repo itself, tracked via git lfs so we don't get annoying slow behavior in the repo.