Skip to content

Fix: fmt() methods applied to groupname_col #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juleswg23 wants to merge 2 commits into from
Closed

Fix: fmt() methods applied to groupname_col #755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61e3cdf
modify where the group label is being fetched from
juleswg23 Aug 8, 2025
c402fc9
minimize change from original code
juleswg23 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion great_tables/_utils_render_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from . import _locations as loc
from ._gt_data import GroupRowInfo, GTData, Styles
from ._spanners import spanners_print_matrix
from ._tbl_data import _get_cell, cast_frame_to_string, replace_null_frame
from ._tbl_data import _get_cell, cast_frame_to_string, is_na, replace_null_frame
from ._text import BaseText, _process_text, _process_text_id
from ._utils import heading_has_subtitle, heading_has_title, seq_groups

Expand Down Expand Up @@ -479,6 +479,14 @@ def create_body_component_h(data: GTData) -> str:
# Only create if this is the first row of data within the group
if group_info is not prev_group_info:
group_label = group_info.defaulted_label()

# If we have a group_label, fetch group label from _tbl_data
# since fmt functions have been applied at this point
if not is_na(tbl_data, group_label):
rowgroup_var = data._boxhead._get_row_group_column()
cell_content: Any = _get_cell(tbl_data, i, rowgroup_var.var)
group_label: str = str(cell_content)

group_class = (
"gt_empty_group_heading" if group_label == "" else "gt_group_heading_row"
)
Expand Down
Loading