Skip to content

Conversation

@juleswg23
Copy link
Contributor

Summary

This PR ensures data for group labels in groupname_col are fetched from the formatted table values, rather than pure text. The example code in the linked issue now outputs:

image

One caveat is I don't know what the expected behavior should be with None/NA values in the groupname_col. This PR is specifically designed with the intention of not modifying the rendering of None/NA values.

Related GitHub Issues and PRs

Closes #236

Checklist

@juleswg23 juleswg23 marked this pull request as draft August 8, 2025 14:29
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.44%. Comparing base (5196b53) to head (c402fc9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage   91.43%   91.44%           
=======================================
  Files          47       47           
  Lines        5547     5551    +4     
=======================================
+ Hits         5072     5076    +4     
  Misses        475      475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juleswg23
Copy link
Contributor Author

Instead of this PR, we can assign group_info.group_label to have formatted/relevant text for display. At the moment it is always None.

When that is done, group_label = group_info.defaulted_label() will get the correct label, and we won't have to implement this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fmt_markdown method doesn't seem to work on groupname_col

2 participants