Skip to content

Fix discreet mode for grouped account list #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buchen merged 2 commits into from
Dec 12, 2025
+6 −6
Merged

Fix discreet mode for grouped account list #5208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856b784
allow discreet mode change to trigger immediately
mierin12 Dec 7, 2025
b59f8b0
simplify following the addition of notifyModelUpdated() method
mierin12 Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/GroupedAccountsListView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,12 @@ protected void notifyViewCreationCompleted()
expandNodes();
}

@Override
public void notifyModelUpdated()
{
groupedAccounts.refresh();
}

@Override
public void onModified(Object element, Object newValue, Object oldValue)
{
Expand All @@ -217,7 +223,6 @@ private void addNewButton(ToolBarManager toolBar)
groupedAccounts.setExpandedState(newItem, true);
// select the newly created account
groupedAccounts.setSelection(new StructuredSelection(newItem));

})))));
}

Expand Down Expand Up @@ -468,10 +473,7 @@ private void deleteFilter(ClientFilterMenu.Item filterItem)
String message = MessageFormat.format(Messages.MenuReportingPeriodDeleteConfirm, filterItem.getLabel());
if (MessageDialog.openConfirm(Display.getDefault().getActiveShell(), Messages.MenuReportingPeriodDelete,
message))
{
items.remove(filterItem);
groupedAccounts.refresh();
}
}

private void deleteElementInFilter(Object element, ClientFilterMenu.Item filterItem)
Expand All @@ -482,7 +484,6 @@ private void deleteElementInFilter(Object element, ClientFilterMenu.Item filterI
// important step: update UUIDs because this is basic
// information in settings
filterItem.setUUIDs(ClientFilterMenu.buildUUIDs(filter.getAllElements()));
groupedAccounts.refresh();
}
}

Expand Down Expand Up @@ -528,7 +529,6 @@ public Image getImage(Object element)
// important step: update UUIDs because this is
// basic information in settings
selectedFilterElement.setUUIDs(ClientFilterMenu.buildUUIDs(filter.getAllElements()));
groupedAccounts.refresh();
}
}
}
Expand Down