Fix discreet mode for grouped account list #5208
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. I believe the notifyModelUpdated is also needed if other data is updated - say that the historical prices are updated in the background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : https://forum.portfolio-performance.info/t/group-accounts-does-not-update/38300
Hello, I can reproduce the issue mentionned above : when on the Grouped account view, if you switch the Discreet Mode, the values of the top table does not immediatly follow the change. It applies if you switch view then go back to grouped account view.
I understand that the change of discreet mode calls
notifyModelUpdated()and therefore this method is added.I think
notifyModelUpdatedis now called also from other actions such as add/delete an element to a grouped account, so in the second commit I am assuming it can be simplified.