-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger Release v1.2.8 #374
Merged
fellowship-merge-bot
merged 6 commits into
polkadot-fellows:main
from
Snowfork:trigger-release-1.2.8
Jul 5, 2024
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c7e2c0b
update changelog
claravanstaden 67ad9a7
bump collectives
claravanstaden 06c58d4
revert kusama relay and AH version bumps
claravanstaden 97c31f1
also remove from changelog
claravanstaden dec50e3
bump kusama
claravanstaden 873e14e
Merge branch 'main' into trigger-release-1.2.8
claravanstaden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acatangiu May you please check the affected chains list? I bumped the Collectives spec version in the PR. The rest have been updated to
1_002_008
already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except Kusama Relay and Kusama Asset Hub.
Looking at their history since last release(s), nothing has changed except a code comment and the bumped spec version you did.
I think we should actually go back/revert to
spec_version: 1_002_006
forKusama Relay Chain
andKusama Asset Hub
.All others have received changes worth releasing (Snowbridge improvement and/or XCM execution filters removed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acatangiu I removed the Kusama AH and relay bump. However, CI wants the Kusama Relay bump: https://github.com/polkadot-fellows/runtimes/actions/runs/9778803977/job/26996484789?pr=374