Trigger Release v1.2.8 #374
Conversation
CHANGELOG.md
Outdated
| Note: This release only affects the following runtimes and is not a full system release: | ||
|
|
||
| - Polkadot Relay Chain | ||
| - Polkadot Asset Hub | ||
| - Polkadot Bridge Hub | ||
| - Polkadot Collectives | ||
| - Kusama Relay Chain | ||
| - Kusama Asset Hub | ||
| - Kusama Bridge Hub |
There was a problem hiding this comment.
@acatangiu May you please check the affected chains list? I bumped the Collectives spec version in the PR. The rest have been updated to 1_002_008 already.
There was a problem hiding this comment.
Everything looks good except Kusama Relay and Kusama Asset Hub.
Looking at their history since last release(s), nothing has changed except a code comment and the bumped spec version you did.
I think we should actually go back/revert to spec_version: 1_002_006 for Kusama Relay Chain and Kusama Asset Hub.
All others have received changes worth releasing (Snowbridge improvement and/or XCM execution filters removed).
There was a problem hiding this comment.
@acatangiu I removed the Kusama AH and relay bump. However, CI wants the Kusama Relay bump: https://github.com/polkadot-fellows/runtimes/actions/runs/9778803977/job/26996484789?pr=374
There was a problem hiding this comment.
@rzadp why is the kusama-migrations CI check expecting spec_version bump when there have been no changes to the runtime (except a code comment AFAICT)? Any way we can bypass it?
@bkchr @joepetrowski what is the rule we actually want here? bump independent runtimes only when there is actually something to release or should we bump and release for any small/noop change?
In general I think it makes sense to release all runtimes as one system version, but of course for some patches / bug fixes it will only be some subset that needs to be upgraded. IMO in these cases it makes sense only to release what needs to be released. |
The check doesn't know what you changed. It just compares the on chain and the current version. Both are the same and thus, it complains. There is no other fix than bumping it right now. |
|
Review required! Latest push from author must always be reviewed |
|
/merge |
fellowship-merge-bot
bot
merged commit 40f849d
into
polkadot-fellows:main
|
Enabled Available commands
For more information see the documentation |
|
Since this includes the Relay Chain, we need to be careful in how we apply it. It should happen after the People Chain is producing blocks. I am planning on a rough timeline like this:
For the Relay Chain, these need to be applied in order, and v1.2.8 can enact after. If you only need to upgrade Bridge Hub, go ahead. |
|
yeah, we can upgrade just BH for now |
|
@joepetrowski how do we actually trigger the release? merging this PR didn't do it by itself.. |
|
Wait patiently: |
Triggers the release of #358 to reduce costs to run the Ethereum client.