Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[encointer] upgrade to polkadot v1.6.0 #193

Closed
wants to merge 118 commits into from
Closed

[encointer] upgrade to polkadot v1.6.0 #193

wants to merge 118 commits into from

Conversation

brenzi
Copy link
Contributor

@brenzi brenzi commented Feb 20, 2024 •
edited
Loading

based on #159

Encointer pallets 5.x.x all depend on polkadot-v1.6.0 crates.io releases
(No changes of pallet functionality)
see: encointer/pallets#370

hint: this version of encointer pallets is compatible with polkadot-v1.7.0 as none of the deps have been bumped upstream

@bkontur
Upgrade to latest: cargo upgrade -v --pinned --incompatible
c1cec95
@bkontur
[FeeManager] fix for XcmFeesToAccount
93f136b
@bkontur
[pallet_identity] adapt paritytech/polkadot-sdk#2048
3c88719 
[pallet_identity] removed `FieldDeposit`, `MaxAdditionalFields`, added `ByteDeposit`
fix import `simple` -> `legacy`
@bkontur
[pallet_staking] removed benchmark payout_stakers_dead_controller
fd6bffa
@bkontur
[pallet_nomination_pools] change import versioned_migrations to `ve…
41fd521 
…rsioned`
@bkontur
[pallet_staking] adapt paritytech/polkadot-sdk#1189
aef83c9
@bkontur
[pallet-staking] adapt paritytech/polkadot-sdk#2380
53f6f9e
@bkontur
[runtime_api::ParachainHost] removed Hash, BlockNumber types
68f77f8
@bkontur
[pallet_nomination_pools] adapt paritytech/polkadot-sdk#2474 (missing…
e23218f 
… `set_commission_claim_permission`)
@bkontur
[pallet-vesting] adapt paritytech/polkadot-sdk#1982
045deca
@bkontur
[ParachainHost] adapt paritytech/polkadot-sdk#2177
0e32f9f
@bkontur
[pallet_xcm] adapt paritytech/polkadot-sdk#2086 (weights: new_query…
3e19b99 
… / `take_response`)
@bkontur
[pallet_xcm] adapt paritytech/polkadot-sdk#1672 (new `reserve_transfe…
a78ffe8 
…r_assets`)
@bkontur
[pallet_xcm] adapt paritytech/polkadot-sdk#2388 (new transfer_assets)
3449ef8
@bkontur
[pallet_collator_selection] adapt paritytech/polkadot-sdk#1340
739170a
@bkontur
[dmp,xcmp,message_queue] adapt paritytech/polkadot-sdk#1246
a7a1cfc
@bkontur
[simple-mermaid] bump
f7a557e
@bkontur
[bridges] adapt paritytech/polkadot-sdk#2602
cb24674
@bkontur
[integration-tests] align integration tests with latest vogue + split…
ee13de8 
…: `common` to `common` and `chains`

chore: remove unneeded deps with `cargo machete` for integration tests
@bkontur
chore: fmt for all
1ccd0f7
@bkontur
fix: "Warning: Error parsing Cargo.toml manifest, fallback to caching…
ca13c92 
… entire file: Error: Invalid TOML document: expected key-value, found comma"

https://github.com/polkadot-fellows/runtimes/actions/runs/7507624988/job/20441549625?pr=137#step:9:1
@bkontur
fix: added rust-src to the stable toolchain components
4b496df
@bkontur
fix: added rust-src to check-migrations
e2564af
@bkontur
[migrations] added `cumulus_pallet_xcmp_queue::migration::v4::Migrati…
e7c1da1 
…onToV4` to SP
@bkontur
[migrations] pallet_nomination_pools::migration::versioned::V7ToV8 …
200f154 
…to relays
@bkontur
WIP: (DNM) Oliver's migration fix for pallet-nominations-pools (fix…
5a13a8c 
… from paritytech/polkadot-sdk#2942)
@bkontur
[migrations] added `pallet_grandpa::migrations::MigrateV4ToV5<Runtime…
58e3ad8 
…>,` to Kusama/Polkadot
@bkontur
fix Cargo.lock after rebase
ab047b0
@bkontur
[chain-specs] Updated relay+paras (except encointer)
ce7edfa
@bkontur
[chain-specs] Updated encointer to polkadot-sdk@1.5
dcee99c
@brenzi brenzi mentioned this pull request Feb 20, 2024
Merged
11 tasks
@acatangiu
Copy link
Contributor

I suggest we merge 159 then this one, squashing them together just creates an even bigger, harder to review PR

acatangiu
acatangiu approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the encointer diff is pretty small, we can merge it with #159

system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs Outdated Show resolved Hide resolved
@brenzi
Copy link
Contributor Author

brenzi commented Feb 21, 2024

I requested a pull into #159 over at @bkontur 's repo: bkontur#2

@brenzi brenzi mentioned this pull request Feb 21, 2024
Merged
@bkontur
Copy link
Contributor

bkontur commented Feb 21, 2024

I requested a pull into #159 over at @bkontur 's repo: bkontur#2

ok, cool, I am busy with other stuff now, but I have this PR in my backlog, don't worry :)

@bkontur bkontur mentioned this pull request Feb 23, 2024
Closed
19 tasks
@bkontur
Copy link
Contributor

bkontur commented Feb 26, 2024

@brenzi I will merge Encointer to 1.6 as a bkontur#4 where I took your PR: bkontur#2
so you can close this and start preparing the same bump for 1.7 :) #187

@brenzi brenzi closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brenzi @acatangiu @bkontur @franciscoaguirre