Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pools 6->7 migration #2942

Merged
merged 14 commits into from
Jan 26, 2024
Merged

Fix Pools 6->7 migration #2942

merged 14 commits into from
Jan 26, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jan 16, 2024

Fix the Pools v7 migration.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 16, 2024
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez I think we need to backport to the 1.5.0-nix and/or 1.6.0

bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 17, 2024
@bkontur

This comment was marked as resolved.

bkontur added a commit to bkontur/runtimes that referenced this pull request Jan 22, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Jan 22, 2024
@ggwpez ggwpez marked this pull request as ready for review January 22, 2024 19:58
@ggwpez ggwpez requested review from a team January 22, 2024 19:58
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@Ank4n Ank4n requested a review from rossbulat January 23, 2024 03:34
- audience: Node Dev
description: |
Restores the behaviour of the nomination pools `V6ToV7` migration so that it still works when
the pallet will be upgraded to V8 afterwards.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description doesn't make sense to me, V6ToV7 will work regardless of V8 as it is always migrated before V8 right? Or is it fixing something that mod v8 broke?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V6ToV7 will work regardless

No sadly not. It should though - which is what this MR is correcting.
The migration tries to access storage from crate::pallet::BondedPoolInner etc, but this could still be unmigrated since the V8 migration could run afterwards.

It did work fine in the past, because the pallet storage definitions were not changed to V8 yet.

@bkontur
Copy link
Contributor

bkontur commented Jan 25, 2024

@ggwpez I think we need to backport to the 1.5.0-nix and/or 1.6.0

@ggwpez What is the status here? Any estimate? I am just asking because of this fellows bump. Thank you :)

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5032736

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkontur
Copy link
Contributor

bkontur commented Jan 26, 2024

I've tested final version in polkadot-fellows repo:
polkadot-fellows/runtimes@d1055fb
https://github.com/polkadot-fellows/runtimes/actions/runs/7666539602/job/20894562729?pr=137
https://github.com/polkadot-fellows/runtimes/actions/runs/7666539602/job/20894562993?pr=137
looks like it is ok

@bkontur bkontur added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@bkontur bkontur added this pull request to the merge queue Jan 26, 2024
Merged via the queue into master with commit dd45c94 Jan 26, 2024
122 of 124 checks passed
@bkontur bkontur deleted the oty-pools-migration branch January 26, 2024 21:15
bkontur pushed a commit that referenced this pull request Jan 26, 2024
bkontur pushed a commit that referenced this pull request Jan 26, 2024
al3mart pushed a commit that referenced this pull request Jan 29, 2024
Fix the Pools `v7` migration.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
acatangiu pushed a commit that referenced this pull request Feb 1, 2024
This should result as a patched `25.0.1` version for
https://crates.io/crates/pallet-nomination-pools/25.0.0.

Relates to: polkadot-fellows/runtimes#159

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
acatangiu added a commit that referenced this pull request Feb 6, 2024
This should result as a patched `24.0.1` version for
https://crates.io/crates/pallet-nomination-pools/24.0.0.

Relates to: polkadot-fellows/runtimes#137

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: PG Herveou <pgherveou@gmail.com>
bkontur added a commit that referenced this pull request Feb 6, 2024
This should result as a patched `24.0.1` version for
https://crates.io/crates/pallet-nomination-pools/24.0.0.

Relates to: polkadot-fellows/runtimes#137

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: PG Herveou <pgherveou@gmail.com>
bkontur added a commit that referenced this pull request Feb 6, 2024
This should result as a patched `25.0.1` version for
https://crates.io/crates/pallet-nomination-pools/25.0.0.

Relates to: polkadot-fellows/runtimes#159

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
acatangiu pushed a commit that referenced this pull request Feb 12, 2024
This is a cherry-pick of
#3093 (patch to
`release-polkadot-v1.6.0`).

This should result as a patched `25.0.1` version for
https://crates.io/crates/pallet-nomination-pools/25.0.0.

Relates to: polkadot-fellows/runtimes#159

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: PG Herveou <pgherveou@gmail.com>
acatangiu added a commit that referenced this pull request Feb 12, 2024
This is a cherry-pick of
#3094 (patch to
`release-polkadot-v1.5.0`).

This should result as a patched `24.0.1` version for
https://crates.io/crates/pallet-nomination-pools/24.0.0.

Relates to: polkadot-fellows/runtimes#137

---------

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: PG Herveou <pgherveou@gmail.com>
Co-authored-by: command-bot <>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Fix the Pools `v7` migration.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants