fix: Disable very old date in timezone test for CI #18935
Conversation
orlp
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
fix
| datetime(1677, 9, 22, tzinfo=ZoneInfo("EST")), | ||
| # Very old dates with a timezone like EST caused problems for the CI due | ||
| # to the IANA timezone database updating their historical offset, so | ||
| # these have been disabled for now. A mismatch between the timezone |
There was a problem hiding this comment.
Is it likely that this mismatch will ever be solved and that's why the tests are commented out or would it be better to just delete the two old dates?
There was a problem hiding this comment.
@rodrigogiraoserrao We might resolve it in the future by loading Python's timezone information instead of hard-baking chrono_tzs timezone database in Polars. And even if we never resolved it I still think it's better to leave the old dates with the explanation so that one in the future might not think to re-add old dates again to 'improve the test'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18935 +/- ##
=======================================
Coverage 79.86% 79.87%
=======================================
Files 1522 1522
Lines 206951 206951
Branches 2906 2906
=======================================
+ Hits 165289 165304 +15
+ Misses 41114 41099 -15
Partials 548 548 ☔ View full report in Codecov by Sentry. |
No description provided.