Skip to content

Commit

Permalink
fix: Disable very old date in timezone test for CI (#18935)
Browse files Browse the repository at this point in the history
  • Loading branch information
orlp authored Sep 26, 2024
1 parent aec911f commit d85240d
Showing 1 changed file with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,7 @@ def test_dt_mean_deprecated() -> None:
@pytest.mark.parametrize(
"value",
[
date(1677, 9, 22),
# date(1677, 9, 22), # See test_literal_from_datetime.
date(1970, 1, 1),
date(2024, 2, 29),
date(2262, 4, 11),
Expand Down Expand Up @@ -1400,8 +1400,13 @@ def test_literal_from_date(
@pytest.mark.parametrize(
"value",
[
datetime(1677, 9, 22),
datetime(1677, 9, 22, tzinfo=ZoneInfo("EST")),
# Very old dates with a timezone like EST caused problems for the CI due
# to the IANA timezone database updating their historical offset, so
# these have been disabled for now. A mismatch between the timezone
# database that chrono_tz crate uses vs. the one that Python uses (which
# differs from platform to platform) will cause this to fail.
# datetime(1677, 9, 22),
# datetime(1677, 9, 22, tzinfo=ZoneInfo("EST")),
datetime(1970, 1, 1),
datetime(1970, 1, 1, tzinfo=ZoneInfo("EST")),
datetime(2024, 2, 29),
Expand Down

0 comments on commit d85240d

Please sign in to comment.