fix(rust): Return empty DF when input is empty json list #18663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanm0000
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18663 +/- ##
==========================================
+ Coverage 79.90% 79.93% +0.02%
==========================================
Files 1512 1512
Lines 203203 203225 +22
Branches 2891 2891
==========================================
+ Hits 162379 162445 +66
+ Misses 40274 40230 -44
Partials 550 550 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Sep 11, 2024
| values, | ||
| self.infer_schema_len | ||
| .unwrap_or(NonZeroUsize::new(usize::MAX).unwrap()), | ||
| )? | ||
| .to_arrow(CompatLevel::newest()) | ||
| ); |
There was a problem hiding this comment.
nit: .map(|supertype| supertype.to_arrow(CompatLevel::newest()))
| }; | ||
| if inner_dtype_result.is_err() { | ||
| match &json_value { |
There was a problem hiding this comment.
Instead of changing the whole dtype inference and control flow. Could we start this function with this check, and just early return DataFrame::empty?
Co-authored-by: coastalwhite <me@gburghoorn.com>
…o columns selected (pola-rs#18772)
…nc executor in new-streaming (pola-rs#18764)
…lars into fix_empty_json_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7355