Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix cum_max using exception text of cum_min for invalid dtype #18780

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

t-ded
Copy link
Contributor

@t-ded t-ded commented Sep 16, 2024

closes #18754

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (6561eba) to head (b95d287).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-ops/src/series/ops/cum_agg.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18780      +/-   ##
==========================================
- Coverage   79.84%   79.82%   -0.02%     
==========================================
  Files        1518     1518              
  Lines      205576   205576              
  Branches     2892     2892              
==========================================
- Hits       164132   164111      -21     
- Misses      40896    40917      +21     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ritchie46 ritchie46 merged commit a7c48a9 into pola-rs:main Sep 17, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cum_max error message for invalid datatype refers to cum_min
2 participants