Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Add 'frame_equal' renamed to 'equals' comment to v1 Upgrade Guide #18044

Closed

Conversation

DeflateAwning
Copy link
Contributor

Fixes #17998

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Aug 4, 2024
@stinodego
Copy link
Member

We do not include all renamings / things that were deprecated before. The list is simply too long. Check out the real changelog for an overview of those functions.

@stinodego stinodego closed this Aug 6, 2024
@DeflateAwning
Copy link
Contributor Author

There is no deprecation warning on this though. Either Deprecation Warnings need to be set reliably, or they need to be included in the upgrade guide.

You make it very difficult to trust upgrading Polars.

Furthermore, @ritchie46 told me to create a PR. I'm now annoyed twice:

  1. That I didn't know about the change before it started breaking things, despite reading every single word in the upgrade guide.
  2. That I wasted my time creating a PR.

Why are you so afraid of the upgrade guide being long? It was a massive upgrade, with lots of breaking changes.

@stinodego
Copy link
Member

There is no deprecation warning on this though.

There was a deprecation warning since 0.19.16, both when using the function and in the docstring.

Plus here's a full overview of scheduled removals, which is part of the release notes:
#16715

@DeflateAwning
Copy link
Contributor Author

Fair enough; TIL my test workflow neglects DeprecationWarnings in unit tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The v1 Upgrade Guide doesn't mention the removal of df.frame_equal(df2)
2 participants