Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check input type in entropy #15351

Merged
merged 1 commit into from
Mar 28, 2024
Merged

feat: check input type in entropy #15351

merged 1 commit into from
Mar 28, 2024

Conversation

ritchie46
Copy link
Member

fixes #15350

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (39b486e) to head (e35a6d8).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15351      +/-   ##
==========================================
+ Coverage   81.37%   81.40%   +0.03%     
==========================================
  Files        1363     1362       -1     
  Lines      176803   176734      -69     
  Branches     2531     2531              
==========================================
  Hits       143869   143869              
+ Misses      32449    32381      -68     
+ Partials      485      484       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 3785fad into main Mar 28, 2024
19 checks passed
@ritchie46 ritchie46 deleted the entropy branch March 28, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

entropy() should error with strings
1 participant
@ritchie46