Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow existential reducers in builders #2533

Merged
merged 1 commit into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Sources/ComposableArchitecture/Reducer/ReducerBuilder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@ public enum ReducerBuilder<State, Action> {
expression
}

@inlinable
@_disfavoredOverload
public static func buildExpression(
_ expression: any Reducer<State, Action>
) -> Reduce<State, Action> {
Reduce(expression)
}

@inlinable
public static func buildFinalResult<R: Reducer>(_ reducer: R) -> R
where R.State == State, R.Action == Action {
Expand Down
7 changes: 7 additions & 0 deletions Tests/ComposableArchitectureTests/ReducerBuilderTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ private struct Test: Reducer {
}
}

func testExistentialReducers() {
_ = CombineReducers {
Test()
Test() as any ReducerOf<Test>
}
}

func testLimitedAvailability() {
_ = CombineReducers {
Test()
Expand Down