Allow existential reducers in builders #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered this while troubleshooting a Swift bug, but seems like we should allow the builder to promote an existential to an erased `Reduce`.
mbrandonw
approved these changes
Oct 29, 2023
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Nov 15, 2023
…ure to from: "1.4.2" (#737) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | minor | `from: "1.3.0"` -> `from: "1.4.2"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.4.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.4.2) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.4.1...1.4.2) #### What's Changed - Fixed: `swift-case-paths` is now correctly pinned from 1.1.0, which should avoid some SPM resolution issues (thanks [@​bdolewski-intellias](https://togithub.com/bdolewski-intellias), [https://github.com/pointfreeco/swift-composable-architecture/pull/2577](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2577)). #### New Contributors - [@​bdolewski-intellias](https://togithub.com/bdolewski-intellias) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2577](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2577) **Full Changelog**: pointfreeco/swift-composable-architecture@1.4.1...1.4.2 ### [`v1.4.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.4.1) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.4.0...1.4.1) #### What's Changed - Fixed: A regression in `Reducer.forEach` was introduced in 1.4 that broke compilation in some cases, notably in the TCACoordinators library. This regression has been corrected (thanks [@​rhysm94](https://togithub.com/rhysm94), [https://github.com/pointfreeco/swift-composable-architecture/pull/2570](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2570)). - Infrastructure: Updated Japanese and Korean README translations (thanks [@​Achoo-kr](https://togithub.com/Achoo-kr), [https://github.com/pointfreeco/swift-composable-architecture/pull/2563](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2563), [https://github.com/pointfreeco/swift-composable-architecture/pull/2562](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2562)). - Infrastructure: Fixed documentation links (thanks [@​johankool](https://togithub.com/johankool), [https://github.com/pointfreeco/swift-composable-architecture/pull/2566](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2566), [https://github.com/pointfreeco/swift-composable-architecture/pull/2576](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2576)); fixed migration guide typos (thanks [@​kalupas226](https://togithub.com/kalupas226), [https://github.com/pointfreeco/swift-composable-architecture/pull/2569](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2569); [@​woxtu](https://togithub.com/woxtu), [https://github.com/pointfreeco/swift-composable-architecture/pull/2575](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2575); [@​Ryu0118](https://togithub.com/Ryu0118), [https://github.com/pointfreeco/swift-composable-architecture/pull/2574](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2574)). - Infrastructure: Clean up case study (thanks [@​mike123789-dev](https://togithub.com/mike123789-dev), [https://github.com/pointfreeco/swift-composable-architecture/pull/2567](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2567)). #### New Contributors - [@​Achoo-kr](https://togithub.com/Achoo-kr) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2563](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2563) - [@​mike123789-dev](https://togithub.com/mike123789-dev) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2567](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2567) - [@​woxtu](https://togithub.com/woxtu) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2575](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2575) - [@​rhysm94](https://togithub.com/rhysm94) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2570](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2570) **Full Changelog**: pointfreeco/swift-composable-architecture@1.4.0...1.4.1 ### [`v1.4.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.4.0) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.3.0...1.4.0) #### What's Changed - Added: The `@Reducer` macro ([https://github.com/pointfreeco/swift-composable-architecture/pull/2553](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2553)). See the [migration guide](https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.4/) for more details. - Added: Reducer builder support for `any Reducer<State, Action>` ([https://github.com/pointfreeco/swift-composable-architecture/pull/2533](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2533)). - Fixed: Silenced a SwiftUI sendability warning ([https://github.com/pointfreeco/swift-composable-architecture/pull/2540](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2540)). - Fixed: Alert and confirmation dialog helpers now use `Text(verbatim: "")` to avoid localization warnings ([https://github.com/pointfreeco/swift-composable-architecture/pull/2541](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2541)). - Fixed: `Reducer.onChange` no longer requires an `Equatable` conformance (thanks [@​lukaskubanek](https://togithub.com/lukaskubanek), [https://github.com/pointfreeco/swift-composable-architecture/pull/2545](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2545)). - Infrastructure: Updated Swift compiler version to 5.7.1 to follow Apple's policy (thanks [@​jaesung-0o0](https://togithub.com/jaesung-0o0), [https://github.com/pointfreeco/swift-composable-architecture/pull/2549](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2549)). - Fixed: Short circuit equatability of ordered sets when counts don't match ([https://github.com/pointfreeco/swift-composable-architecture/pull/2556](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2556)). - Infrastructure: Added previews to integration test cases by ([https://github.com/pointfreeco/swift-composable-architecture/pull/2551](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2551)) #### New Contributors - [@​lukaskubanek](https://togithub.com/lukaskubanek) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2545](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2545) **Full Changelog**: pointfreeco/swift-composable-architecture@1.3.0...1.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this while troubleshooting a Swift bug, but seems like we should allow the builder to promote an existential to an erased
Reduce.