Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#default expanded treeItem #1084

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Conversation

amirmsai
Copy link
Contributor

@amirmsai amirmsai commented Dec 28, 2021

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

define the default expanded items in the tree

Guidance

  • You can delete this section when you are submitting the pull request.
  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to dev branch.

@amirmsai amirmsai mentioned this pull request Dec 28, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jan 8, 2022

Hi @amirmsai - thanks for the PR.
Could you please explain the logic of this property? Especially when it works in combination with defaultSelectedNodes.
The final "set" of the expanded node would be an aggregation of the ones from new property and the ones that are expanded because on the selection?

@amirmsai
Copy link
Contributor Author

amirmsai commented Jan 9, 2022 via email

@AJIXuMuK
Copy link
Collaborator

Sorry @amirmsai - could you please provide an example?
Let's say I have some defaultExpandedKeys and I also have expandToSelected set to true and some defaultSelectedKeys. What will be the result for the expanded items in the tree? Union? Intersection? or one property will be ignored?

@amirmsai
Copy link
Contributor Author

amirmsai commented Feb 17, 2022 via email

@AJIXuMuK
Copy link
Collaborator

Thanks @amirmsai!
I will merge the PR and will see how it works in different configurations.

@AJIXuMuK AJIXuMuK merged commit fa80567 into pnp:dev Mar 18, 2022
@AJIXuMuK AJIXuMuK added this to the 3.7.0 milestone Mar 18, 2022
@amirmsai
Copy link
Contributor Author

amirmsai commented Mar 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants