-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in TreeView #1062
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Hi @tounsiAli, Thank you for the suggestion. Thanks! |
Hi Alex,
how can i do it ?
Le sam. 4 déc. 2021 à 18:30, Alex Terentiev ***@***.***> a
écrit :
… Hi @tounsiAli <https://github.com/tounsiAli>,
Thank you for the suggestion.
As you've already dig into it - would you be interested in submitting the
PR?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1062 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKWKK24NQPAESSMEKI24PITUPJF37ANCNFSM5H5PROAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Hi @tounsiAli - here is the documentation on how to contribute: https://pnp.github.io/sp-dev-fx-controls-react/guides/contributing/#tips In few words - you need to "fork" the repo, create a branch based on |
Hello,
the changes are defined. I created a PR #default expanded treeItem by
tounsiAli · Pull Request #1084 · pnp/sp-dev-fx-controls-react (github.com)
<#1084>
Amir MSAI
Le mar. 7 déc. 2021 à 15:08, Alex Terentiev ***@***.***> a
écrit :
… Hi @tounsiAli <https://github.com/tounsiAli> - here is the documentation
on how to contribute:
https://pnp.github.io/sp-dev-fx-controls-react/guides/contributing/#tips
In few words - you need to "fork" the repo, create a branch based on dev,
do the changes, push the branch and then create a PR in our repo from your
branch to dev.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1062 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKWKK22L63KP6IJMWLFZEQLUPYINBANCNFSM5H5PROAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Hello,
can you please add my name "Amir MSAI" like a contributor :)
thanks
Amir MSAI
Le mar. 28 déc. 2021 à 16:11, msai amir ***@***.***> a écrit :
… Hello,
the changes are defined. I created a PR #default expanded treeItem by
tounsiAli · Pull Request #1084 · pnp/sp-dev-fx-controls-react (github.com)
<#1084>
Amir MSAI
Le mar. 7 déc. 2021 à 15:08, Alex Terentiev ***@***.***> a
écrit :
> Hi @tounsiAli <https://github.com/tounsiAli> - here is the documentation
> on how to contribute:
> https://pnp.github.io/sp-dev-fx-controls-react/guides/contributing/#tips
>
> In few words - you need to "fork" the repo, create a branch based on dev,
> do the changes, push the branch and then create a PR in our repo from your
> branch to dev.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1062 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AKWKK22L63KP6IJMWLFZEQLUPYINBANCNFSM5H5PROAA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
The changes have been merged and will be available in the next release. |
To define the expanded nodes and dont lose it after a refresh: only to add a block of code in TreeviewItem in componentWillReceiveProps,
It will be like this:
public componentWillReceiveProps(nextProps: IMyTreeItemProps): void {
// If selection is turned on, set the item as selected
if (this.props.selectionMode != MyTreeViewSelectionMode.None) {
let active = nextProps.activeItems.filter(item => item.key === this.props.treeItem.key);
}
And add the property defaultExpandedKeys?: string[]; in TreeViewProps
The text was updated successfully, but these errors were encountered: