Skip to content

Issue 156: update SZip and ScaleOffset enums#157

Merged
jkotan merged 1 commit intodevelopfrom
issue_156
Jan 19, 2022
Merged

Issue 156: update SZip and ScaleOffset enums#157
jkotan merged 1 commit intodevelopfrom
issue_156

Conversation

@jkotan
Copy link
Copy Markdown
Collaborator

@jkotan jkotan commented Jan 12, 2022

It resolves #156 by updating SZip and ScaleOffset enums

One test fails

self = <test.h5cpp_tests.node_tests.dataset_extent_test.DatasetExtentTest testMethod=testGrowExtentLimited>

    def testGrowExtentLimited(self):
    
        dataset = Dataset(self.root, h5cpp.Path("GrowExtentLimited"),
                          kFloat32,
                          self.limited_dataspace,
                          self.lcpl,
                          self.dcpl)
        dataset.extent(0, 10)
        self.assertEqual(dataset.dataspace.current_dimensions, (20, 10))
    
        self.assertRaises(RuntimeError, dataset.extent, 0, 90)
        self.assertRaises(RuntimeError, dataset.extent, 1, 1)
        self.assertEqual(dataset.dataspace.current_dimensions, (20, 10))
    
        #
        # shrink the dataset again
        #
>       dataset.extent(0, -2)
E       RuntimeError: input value is < 0 -> cannot be converted to unsigned

test/h5cpp_tests/node_tests/dataset_extent_test.py:121: RuntimeError

but it is related to ess-dmsc/h5cpp#568 and will be fixed by ess-dmsc/h5cpp#569

@jkotan jkotan merged commit 8b905eb into develop Jan 19, 2022
@jkotan jkotan deleted the issue_156 branch January 19, 2022 10:03
@jkotan jkotan mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update filters for h5cpp v1.0.0

1 participant