Skip to content

Conversation

@CodyJasonBennett
Copy link
Member

Resolves pmndrs/react-three-fiber#2848 by updating GLTFLoader with three.js.

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
three-stdlib ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2023 9:43am

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2508dfc:

Sandbox Source
three-stdlib-ssr Configuration

@CodyJasonBennett CodyJasonBennett merged commit 73531c8 into pmndrs:main Apr 27, 2023
@CodyJasonBennett CodyJasonBennett deleted the fix/upstream-gltfloader branch April 27, 2023 11:00
@github-actions
Copy link

🎉 This PR is included in version 2.21.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@makc
Copy link

makc commented May 3, 2023

lol. @CodyJasonBennett does this mean that three-stdlib can no longer work with older three.js 🥲

@makc
Copy link

makc commented May 3, 2023

package.json still says

  "peerDependencies": {
    "three": ">=0.122.0"
  }

🥲

@CodyJasonBennett
Copy link
Member Author

That's not what this PR does. I routinely mirror fixes here as I make them in three.js but it has no unusual implications on semver.

@makc
Copy link

makc commented May 3, 2023

@CodyJasonBennett I was under impression that the new loader makes uv1 where the old one used to make uv2. This sounds like something that would have implications on semver to me 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

three-stdlib - GLTFLoader: Cannot read properties of undefined (reading 'value')

2 participants