Merge stable 1.13 to master #5623
Conversation
- add workflows' descriptions (and update existing ones), - simplify workflows, - update triggers, - clean up redundant steps, packages, - general cleanup (like fixing indentation).
don't run bash and python tests sequentially, because failure of the first run, may hide issue in the second one.
- replace separate script to build pmdk docs with a single command, - rename check_docs script, - always use libpmem2 in check_docs - remove redundant parameter.
Update GHA workflows
- clean redundant packages, - make order in ENV variables, - update comments, - update maintainer.
The "sudo ndctl clear-errors" command resets permissions of the DAX block device and its resource files because it removes the old files and creates new ones with default permissions which interrupts further test execution. The following commands set permissions which should allow further test execution to work around this issue. Ref: pmem#5606 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
common: docker cleanups
ex_libpmem2/TEST6 would require two VALGRIND_SET_CLEAN() calls to be added to the "src/examples/libpmem2/ringbuf/ringbuf.c" example (see pmem#5604) in order to pass under pmemcheck, but it seems that examples do not use valgrind macros on purpose (to avoid unnecessary complication), so this test just should not be run under pmemcheck. Fixes: pmem#5598 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
…AX-devices-after-clearing-bad-blocks test: update permissions of DAX devices after clearing bad blocks
…d-not-be-run-under-pmemcheck test: ex_libpmem2/TEST6 should not be run under pmemcheck
Since this file, is for linux only, there is no need to use #ifndef
pmem2: fix valgrind instrumentation in pmem2_map_from_exisiting
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, 1 of 1 files at r2, 2 of 3 files at r3, 8 of 9 files at r8, 1 of 1 files at r9, 2 of 2 files at r10, 2 of 2 files at r11.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @janekmi)
pmem2: remove unnecessary #ifndef
janekmi
force-pushed
the
merge-stable-1.13-to-master
branch
from
dc86bc4 to
fecde0c
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r12, 2 of 2 files at r13, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r11, 1 of 3 files at r12, 2 of 2 files at r13, all commit messages.
Reviewable status:
Codecov Report
@@ Coverage Diff @@
## master #5623 +/- ##
==========================================
+ Coverage 72.24% 74.25% +2.01%
==========================================
Files 146 146
Lines 22634 22132 -502
Branches 3771 3705 -66
==========================================
+ Hits 16351 16434 +83
+ Misses 6283 5698 -585 |
There was a problem hiding this comment.
Reviewed 1 of 12 files at r1.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
|
FYI, I'd wait for #5622 and (at least) one future PR with CI fixes. |
There was a problem hiding this comment.
Reviewed 9 of 12 files at r1, 1 of 1 files at r2, 2 of 3 files at r3, 8 of 9 files at r8, 1 of 1 files at r9, 1 of 2 files at r10, 1 of 3 files at r12, 2 of 2 files at r13, all commit messages.
Reviewable status:
There was a problem hiding this comment.
We can do one more merge later. For now, it is most important to fix master branch dax0.2 issue
Reviewable status:
This change is