test: update permissions of DAX devices after clearing bad blocks

[ldorau]

The "sudo ndctl clear-errors" command resets permissions of DAX block device and its resource files,
because it removes the old files and creates new ones with default permissions, so their permissions have to be updated.

Fixes: #5606

---

This change is 

[grom72]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

[osalyk]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

[grom72]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

[codecov]

Codecov Report

Merging #5611 (b207bcd) into stable-1.13 (705eca0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           stable-1.13    #5611      +/-   ##
===============================================
- Coverage        74.26%   74.25%   -0.01%     
===============================================
  Files              145      145              
  Lines            22131    22131              
  Branches          3704     3705       +1     
===============================================
- Hits             16435    16433       -2     
- Misses            5696     5698       +2     

[ldorau]

Added "Ref: #5606" to the commit message.

[ldorau]

Rebased to pmem:stable-1.13.

[grom72]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

[janekmi]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ldorau)

---

src/test/unittest/badblock.py line 113 at r2 (raw file):

            # because it removes the old files and creates new ones
            # with default permissions, so their permissions
            # have to be updated.

updated -> restored?

Please see the comment below.

---

src/test/unittest/badblock.py line 119 at r2 (raw file):

            futils.run_command("sudo chmod a+r {}".format(resources),
                               "failed to change permissions "
                               "of DAX devices' resources")

I thought about reading the permissions before calling the culprit command and using the output to restore the permissions as if they were before calling the command.

Would it be that much more complex?

[ldorau]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)

---

src/test/unittest/badblock.py line 113 at r2 (raw file):

Previously, janekmi (Jan Michalski) wrote…

updated -> restored?

Please see the comment below.

updated -> fixed ?

---

src/test/unittest/badblock.py line 119 at r2 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I thought about reading the permissions before calling the culprit command and using the output to restore the permissions as if they were before calling the command.

Would it be that much more complex?

I'm sure it would be much more complex. There can be a lot of those files. How do you want to do that? Is it worth this effort? I doubt.

[janekmi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ldorau)

---

src/test/unittest/badblock.py line 113 at r2 (raw file):
What would you say to write it down as follows:

The "sudo ndctl clear-errors" command resets permissions of the DAX block device and its resource files because it removes the old files and creates new ones with default permissions which interrupts further test execution. The following commands set permissions which should allow further test execution to work around this issue.

---

src/test/unittest/badblock.py line 119 at r2 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…

I'm sure it would be much more complex. There can be a lot of those files. How do you want to do that? Is it worth this effort? I doubt.

Alright. You convinced me. 😆 I think I have to find a way to cut the corners in general to address everything we currently got on our plate. 👍

[ldorau]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72, @janekmi, and @osalyk)

---

src/test/unittest/badblock.py line 113 at r2 (raw file):

Previously, janekmi (Jan Michalski) wrote…

What would you say to write it down as follows:

The "sudo ndctl clear-errors" command resets permissions of the DAX block device and its resource files because it removes the old files and creates new ones with default permissions which interrupts further test execution. The following commands set permissions which should allow further test execution to work around this issue.

Done.

[osalyk]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)

[lukaszstolarczuk]

👍

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)

[janekmi]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)